fix(@aws-amplify/auth): incorrect return type for Auth.resendSignUp

[mousedownmike]

Partial fix for #5029

Updated Auth.resendSignUp signature to return any type instead of string. Revised Spy to be reflective of an actual CodeDeliveryDetails response.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[codecov]

Codecov Report

Merging #5112 into main will decrease coverage by 0.17%.
The diff coverage is 85.77%.

@@            Coverage Diff             @@
##             main    #5112      +/-   ##
==========================================
- Coverage   73.48%   73.31%   -0.18%     
==========================================
  Files         205      208       +3     
  Lines       12621    12922     +301     
  Branches     2460     2526      +66     
==========================================
+ Hits         9275     9474     +199     
- Misses       3157     3257     +100     
- Partials      189      191       +2     

Impacted Files	Coverage Δ
packages/api/src/API.ts	95.12% <ø> (ø)
packages/auth/src/OAuth/OAuth.ts	56.11% <0.00%> (+6.47%)	⬆️
packages/datastore/src/sync/index.ts	15.38% <0.00%> (-0.06%)	⬇️
packages/datastore/src/sync/processors/mutation.ts	13.19% <0.00%> (ø)
...ages/datastore/src/sync/processors/subscription.ts	42.58% <0.00%> (-0.28%)	⬇️
...pubsub/src/Providers/AWSAppSyncRealTimeProvider.ts	18.54% <0.00%> (ø)
...ges/analytics/src/Providers/AWSPinpointProvider.ts	74.69% <20.00%> (-0.84%)	⬇️
...kages/aws-amplify-react/src/Auth/Authenticator.tsx	71.85% <20.00%> (-3.74%)	⬇️
packages/storage/src/providers/AWSS3Provider.ts	86.97% <66.66%> (-0.33%)	⬇️
...torage/src/providers/AWSS3ProviderManagedUpload.ts	92.66% <75.00%> (-2.44%)	⬇️
... and 19 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d3d7a8...7cc8966. Read the comment docs.

[ericclemmons]

This is looking great! Thanks for this.

We still need to validate the PR, but I had a question about Promise<any> first. 🤞

[ericclemmons]

It possible to re-use CodeDeliveryDetails here?

amplify-js/packages/amazon-cognito-identity-js/index.d.ts

Lines 6 to 10 in ac34816

	export interface CodeDeliveryDetails {
	AttributeName: string;
	DeliveryMedium: string;
	Destination: string;
	}

[mousedownmike]

@ericclemmons are we sure it always resolves to CodeDeliveryDetails? I wasn't positive so I chose any. The code builds fine with CodeDelieryDetails in there and I can push that if you'd like.

[mousedownmike]

The branch with CodeDeliveryDetails is here:
https://github.com/mousedownmike/amplify-js/tree/resendsignup_codedeliverydetails

Happy to close this PR and start a new one or merge the change into this one. Whichever solution works best and whenever it works.

Cheers,
Mike

[ericclemmons]

I'm going to get this merged in once tests pass.

We'll do some more tests to confirm the payload shape, but for now this is a great step forward 👍

[ericclemmons]

(I went ahead & opened #6561 for comparison)

[ericclemmons]

Everything looks good, though we'll need to manually validate the response payload against the types to be sure whether any is the correct type.

The underlying call indicates a string, but we have to be certain to avoid run-time errors during this crucial flow:

amplify-js/packages/amazon-cognito-identity-js/src/CognitoUser.js

Lines 1280 to 1286 in ac34816

	/**
	* This is used by a user to resend a confirmation code
	* @param {nodeCallback<string>} callback Called on success or error.
	* @param {ClientMetadata} clientMetadata object which is passed from client to Cognito Lambda trigger
	* @returns {void}
	*/
	resendConfirmationCode(callback, clientMetadata) {

[f22hd]

Exactly what we added to our project to resolve this mistype of the return type.
Hope this PR gets approved. Thanks.

[ericclemmons]

I'm going to get this merged in once tests pass.

We'll do some more tests to confirm the payload shape, but for now this is a great step forward 👍

[github-actions]

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.