fix(secure_storage): process file system operations one at a time on Windows #5195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jordan-Nelson
changed the title
Jordan-Nelson
changed the title
Jordan-Nelson
changed the title
Jordan-Nelson
changed the title
tyllark
reviewed
Jul 23, 2024
| final data = await readAll(); | ||
| data[key] = value; | ||
| return writeAll(data); | ||
| }); | ||
| } | ||
|
|
||
| /// Overwrites the existing data. |
There was a problem hiding this comment.
Should writeAll be wrapped by the scheduler as well?
There was a problem hiding this comment.
Discussed offline - I updated writeAll and readAll to be annotated with @visibleForTesting as these apis are really private and only exposed for testing.
Equartey
approved these changes
Jul 25, 2024
tyllark
approved these changes
Jul 25, 2024
CarlosEspinozaMaruri
approved these changes
Jul 29, 2024
tyllark
pushed a commit
to tyllark/amplify-flutter
that referenced
this pull request
Aug 14, 2024
…Windows (aws-amplify#5195) * fix(secure_storage): process fs events in the order they are received * chore: clear file when it is corrupted * chore: add test for stale data during parallel writes * chore: add visibleForTesting annotations * chore: add tests for in-memory fs and local fs * chore: remove print from test
tyllark
pushed a commit
that referenced
this pull request
Aug 20, 2024
…Windows (#5195) * fix(secure_storage): process fs events in the order they are received * chore: clear file when it is corrupted * chore: add test for stale data during parallel writes * chore: add visibleForTesting annotations * chore: add tests for in-memory fs and local fs * chore: remove print from test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #5190
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.