New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(secure_storage): handle parallel read/write/delete operations on Windows #5194

Closed

Jordan-Nelson wants to merge 1 commit into aws-amplify:main from Jordan-Nelson:fix/secure_storage/process-events

Member

Jordan-Nelson commented Jul 23, 2024

Issue #, if available: #5190

Description of changes:

Update FileKeyValueStore to process tasks one at a time in the order in which they are received

This PR accomplished two things:

Addresses a bug on Windows in which the file can become corrupted when there are many multiple writes/deletes occurring without awaiting them. On windows it appears that it is not safe to make multiple File system API calls in parallel (MacOS does not have this issue).
Ensures that even if the caller does not await write/delete events, that they are processed in the order in which they are received.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.


          fix(secure_storage): process fs events in the order they are received

Member Author

Jordan-Nelson commented Jul 23, 2024

Closing in favor of #5195

Jordan-Nelson closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet