-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(amplify-codegen): change flutter import from datastore to core #277
feat(amplify-codegen): change flutter import from datastore to core #277
Conversation
Tag release for flutter custom type
fix: add prerelease version
Tag release for read only fields in dart
Codecov Report
@@ Coverage Diff @@
## tagged-release/custom-type-preview #277 +/- ##
======================================================================
+ Coverage 85.34% 85.37% +0.03%
======================================================================
Files 145 145
Lines 6911 6921 +10
Branches 1750 1751 +1
======================================================================
+ Hits 5898 5909 +11
+ Misses 922 921 -1
Partials 91 91
Continue to review full report at Codecov.
|
[Tagged release]: add auth provider in flutter modelgen
…degen into tagged-release/custom-type-preview
…/flutter-deps-datastore-to-core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🍵
This PR changes amplify-flutter (dart) codegen models so that they import from the core plugin instead of the datastore_plugin_interface. This is part of an effort in the next major version of amplify-flutter to allow customers to use codegen models without taking on a datastore dependency. One of the features in this change is model-based GraphQL helpers for the API category. That feature will allow users to have codegen files in an app that uses the API category without the datastore category. For that reason, codegen dependencies should come from core so they can be used with datastore or API exclusively. There is an amplify-flutter change to make those available in core aws-amplify/amplify-flutter#1023.
This codegen change is desired to be made available via a preview release so customers can use it during the preview stage of amplify-flutter 0.3.0 release (0.3.0-rc.x). For that reason, this PR is against the tagged-release/custom-type branch so it can use the same preview tag (presumably with incremented number). These changes are intended for use with same major version (and preview releases) of amplify-flutter.
Description of how you validated changes
In codegen repo (on branch for this PR): ran
setup-dev
andyarn setup-dev
to make local changes available.In amplify-flutter (on branch with deps moved), went to datastore example app and ran
amplify-dev codegen models
. With locally updated codegen models, ran the integration tests on android and ios, as well as flutter unit tests.In amplify-flutter, in separate branch for model helpers, ran the same codegen command in API example app without datastore (to test API only use). flutter unit tests and integration tests pass there.
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.