Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag release for read only fields in dart #264

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

AaronZyLee
Copy link
Contributor

@AaronZyLee AaronZyLee commented Oct 15, 2021

Description of changes

Add read only fields in dart modelgen

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • Breaking changes to existing customers are released behind a feature flag or major version update
  • Changes are tested using sample applications for all relevant platforms (iOS/android/flutter/Javascript) that use the feature added/modified

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

* feat(appsync-modelgen-plugin): add readOnly fields in dart

* fix: obsolete snapshots
@AaronZyLee AaronZyLee requested a review from a team as a code owner October 15, 2021 19:10
@AaronZyLee AaronZyLee requested a review from a team October 15, 2021 19:10
@AaronZyLee AaronZyLee changed the title feat(appsync-modelgen-plugin): add readOnly fields in dart (#263) Tag release for read only fields in dart Oct 15, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #264 (87064c5) into tagged-release/custom-type-preview (d15504d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                          Coverage Diff                           @@
##           tagged-release/custom-type-preview     #264      +/-   ##
======================================================================
+ Coverage                               85.70%   85.71%   +0.01%     
======================================================================
  Files                                     145      145              
  Lines                                    6701     6708       +7     
  Branches                                 1543     1575      +32     
======================================================================
+ Hits                                     5743     5750       +7     
- Misses                                    877      884       +7     
+ Partials                                   81       74       -7     
Impacted Files Coverage Δ
...nc-modelgen-plugin/src/visitors/appsync-visitor.ts 95.72% <ø> (+0.30%) ⬆️
...delgen-plugin/src/visitors/appsync-dart-visitor.ts 97.03% <100.00%> (+0.03%) ⬆️
...elgen-plugin/src/visitors/appsync-swift-visitor.ts 95.43% <0.00%> (-0.34%) ⬇️
...kages/graphql-types-generator/src/swift/helpers.ts 94.06% <0.00%> (ø)
...c-modelgen-plugin/src/utils/process-connections.ts 92.13% <0.00%> (ø)
...odelgen-plugin/src/utils/process-connections-v2.ts 90.32% <0.00%> (ø)
...delgen-plugin/src/visitors/appsync-java-visitor.ts 93.02% <0.00%> (ø)
...ugin/src/languages/typescript-declaration-block.ts 72.38% <0.00%> (ø)
...tor/src/compiler/visitors/collectAndMergeFields.ts 92.45% <0.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d15504d...87064c5. Read the comment docs.

@AaronZyLee AaronZyLee merged commit 8b5549a into tagged-release/custom-type-preview Oct 15, 2021
@dpilch dpilch deleted the non-model-flutter branch October 27, 2021 14:53
@dpilch dpilch restored the non-model-flutter branch October 27, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants