Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: prepend @aws-amplify to amplify-app dependency #12031

Merged
merged 16 commits into from
Feb 20, 2023
Merged

chore: prepend @aws-amplify to amplify-app dependency #12031

merged 16 commits into from
Feb 20, 2023

Conversation

aws-eddy
Copy link
Contributor

@aws-eddy aws-eddy commented Feb 17, 2023 •
edited
Loading

Description of changes

Adding scoping for amplify-app and made a tagged release to test the dependency.

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • [n/a] Tests are changed or added
  • [n/a] Relevant documentation is changed or added (and PR referenced)
  • [n/a] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

aws-eddy and others added 11 commits February 6, 2023 16:19
@aws-eddy
chore: adding scoping for amplify-app
7ff4c12
@aws-eddy
adding dependency withing package.json
205376f
@aws-eddy @lazpavel
@goldbez @sdstolworthy @jhockett
chore: prepend @aws-amplify to amplify-category-function (aws-amplify…
91d62da 
…#11923)

* chore: merging dev into feature branch (aws-amplify#11920)

* chore: migrate predictions category from inquirer to prompter

* fix: amplify-prompts import

* feat: revamp help command (aws-amplify#11667)

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command (resolving merge conflicts)

* feat: revamp help command (remove non-null assertions)

* feat: revamp help command (remove non-null assertions)

* feat: revamp help command (revisions)

* feat: revamp help command (revisions)

* feat: revamp help command (revisions)

* feat: revamp help command (update to use array find)

* feat: revamp help command (switch to single quotes)

* feat: revamp help command (switch to single quotes)

* feat: revamp help command (put imports on same line)

* feat: revamp help command (extract api)

* feat: revamp help command (prettier on help-helpers)

* feat: revamp help command (fix tag line)

* feat: revamp help command (changing test names)

* feat: revamp help command (refactoring preserveHelpInformation)

* chore: fix unit test for predictions prompter migration

* chore: fix delete project unit test for predictions prompter migration

* chore: added prompterAdapter class to handle prompt objects by type

* chore: updated migration tests to use a different version of push as prompter interaction changed in this PR

* chore: fix predictions e2e test as the new prompt will auto-select the single option

* chore: removed unused import

* chore: fixed codeQL warnings

* chore: fix migration tests using inquirer prompts

* chore: e2e tests affected by inquirer to prompts change

* chore: e2e tests affected by inquirer to prompts change

* chore: split log running tests

* chore: addressing PR feedback

* test: fix e2e test runAsync error validation

* chore: replaced static string literal as dynamic key with field name

* fix: modal windows test for opensearch simulator (aws-amplify#11911)

* fix: modal windows test for opensearch simulator

* fix: don't run opensearch-simulator test on windows

* feat: force version bump (aws-amplify#11913)

* chore: fix dependency versions and update clean command (aws-amplify#11915)

---------

Co-authored-by: Pavel Lazar <[email protected]>
Co-authored-by: lazpavel <[email protected]>
Co-authored-by: Zachary Goldberg <[email protected]>
Co-authored-by: Spencer Stolworthy <[email protected]>
Co-authored-by: John Hockett <[email protected]>

* merging dev into @aws-amplify-scoping (aws-amplify#11921)

* chore: migrate predictions category from inquirer to prompter

* fix: amplify-prompts import

* feat: revamp help command (aws-amplify#11667)

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command (resolving merge conflicts)

* feat: revamp help command (remove non-null assertions)

* feat: revamp help command (remove non-null assertions)

* feat: revamp help command (revisions)

* feat: revamp help command (revisions)

* feat: revamp help command (revisions)

* feat: revamp help command (update to use array find)

* feat: revamp help command (switch to single quotes)

* feat: revamp help command (switch to single quotes)

* feat: revamp help command (put imports on same line)

* feat: revamp help command (extract api)

* feat: revamp help command (prettier on help-helpers)

* feat: revamp help command (fix tag line)

* feat: revamp help command (changing test names)

* feat: revamp help command (refactoring preserveHelpInformation)

* chore: fix unit test for predictions prompter migration

* chore: fix delete project unit test for predictions prompter migration

* chore: added prompterAdapter class to handle prompt objects by type

* chore: updated migration tests to use a different version of push as prompter interaction changed in this PR

* chore: fix predictions e2e test as the new prompt will auto-select the single option

* chore: removed unused import

* chore: fixed codeQL warnings

* chore: fix migration tests using inquirer prompts

* chore: e2e tests affected by inquirer to prompts change

* chore: e2e tests affected by inquirer to prompts change

* chore: split log running tests

* chore: addressing PR feedback

* test: fix e2e test runAsync error validation

* chore: replaced static string literal as dynamic key with field name

* fix: modal windows test for opensearch simulator (aws-amplify#11911)

* fix: modal windows test for opensearch simulator

* fix: don't run opensearch-simulator test on windows

* feat: force version bump (aws-amplify#11913)

* chore: fix dependency versions and update clean command (aws-amplify#11915)

---------

Co-authored-by: Pavel Lazar <[email protected]>
Co-authored-by: lazpavel <[email protected]>
Co-authored-by: Zachary Goldberg <[email protected]>
Co-authored-by: Spencer Stolworthy <[email protected]>
Co-authored-by: John Hockett <[email protected]>

* chore: prepend @aws-amplify to amplify-category-function

* chore: yarn extract-api

---------

Co-authored-by: Pavel Lazar <[email protected]>
Co-authored-by: lazpavel <[email protected]>
Co-authored-by: Zachary Goldberg <[email protected]>
Co-authored-by: Spencer Stolworthy <[email protected]>
Co-authored-by: John Hockett <[email protected]>
@aws-eddy
chore: prepend @aws-amplify to amplify-category-interactions (aws-amp…
b250281 
…lify#11930)

* prepend @aws-amplify to amplify-categor-interactions

* chore: fixing yarn extract-api
@aws-eddy
chore: prepend @aws-amplify to amplify-category-geo (aws-amplify#11926)
4e62ac6 
* chore: prepend @aws-amplify to amplify-category-geo

* chore: running yarn extract

* chore: fixing yarn extract-api
@aws-eddy
chore: prepend @aws-amplify to amplify-category-analytics (aws-amplif…
87f35b6 
…y#11922)

* adding aws-amplify to category analytics package

* chore: syncing with dev

* chore: fixing yarn.lock

* chore: yarn extract-api

* chore: fixing extract-api
@aws-eddy
chore: prepend aws/amplify to amplify-category-hosting (aws-amplify#1…
c1d821c 
…1929)

* chore: adding @aws-amplify to hosting category dep

* prepend aws-amplify for amplify hosting dependency

* chore: running yarn extract

* chore: fixing yarn extract-api
@aws-eddy
Merge branch 'aws-amplify-scoping' into dependency-scope/amplify-app
8711895
@aws-eddy
Merge branch 'dev' into dependency-scope/amplify-app
2cf8124
@aws-eddy
chore: regenerate yarn.lockfile
06449c8
@aws-eddy
Merge branch 'dev' into dependency-scope/amplify-app
a0a07b0
@aws-eddy aws-eddy marked this pull request as ready for review February 17, 2023 17:42
@aws-eddy aws-eddy requested a review from a team as a code owner February 17, 2023 17:42
@aws-eddy aws-eddy added the dependency-issue Issue with another dependency used label Feb 17, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #12031 (b74d8c2) into dev (984c0f8) will decrease coverage by 3.48%.
The diff coverage is 53.81%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              dev   #12031      +/-   ##
==========================================
- Coverage   49.45%   45.97%   -3.48%     
==========================================
  Files         692      819     +127     
  Lines       33424    37689    +4265     
  Branches     6840     7724     +884     
==========================================
+ Hits        16529    17329     +800     
- Misses      15370    18685    +3315     
- Partials     1525     1675     +150
Impacted Files Coverage Δ
...sync-simulator/src/data-loader/opensearch/index.ts 45.45% <0.00%> (ø)
...s/amplify-appsync-simulator/src/type-definition.ts 100.00% <ø> (ø)
...sync-simulator/src/velocity/util/dynamodb-utils.ts 6.55% <0.00%> (ø)
...y-appsync-simulator/src/velocity/util/map-utils.ts 10.00% <ø> (ø)
...tor/src/velocity/util/transform/dynamodb-filter.ts 4.93% <0.00%> (ø)
...ync-simulator/src/velocity/util/transform/index.ts 21.05% <0.00%> (ø)
...appsync-simulator/src/velocity/value-mapper/map.ts 86.88% <ø> (ø)
...ackages/amplify-category-auth/src/commands/auth.ts 0.00% <0.00%> (ø)
...es/amplify-category-auth/src/commands/auth/help.ts 0.00% <0.00%> (ø)
.../amplify-category-auth/src/commands/auth/import.ts 0.00% <0.00%> (ø)
... and 534 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aws-eddy aws-eddy requested a review from sobolk February 20, 2023 19:57
@aws-eddy aws-eddy merged commit 0e12dff into aws-amplify:dev Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolk sobolk sobolk approved these changes

@jhockett jhockett jhockett approved these changes

Assignees
No one assigned
Labels
dependency-issue Issue with another dependency used
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aws-eddy @codecov-commenter @jhockett @sobolk