Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepend @aws-amplify to amplify-category-interactions #11930

Conversation

aws-eddy
Copy link
Contributor

@aws-eddy aws-eddy commented Feb 7, 2023

Description of changes

adding @aws-amplify to npm package for amplify-category-interactions to prevent malicious users from impersonation AWS Amplify

Issue #, if available

Description of how you validated changes

yarn test passes locally

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aws-eddy aws-eddy requested a review from a team as a code owner February 7, 2023 18:06
@aws-eddy aws-eddy changed the base branch from @aws-amplify-scoping to aws-amplify-scoping February 8, 2023 03:48
@aws-eddy aws-eddy added the dependency-issue Issue with another dependency used label Feb 8, 2023
@aws-eddy aws-eddy merged commit b250281 into aws-amplify:aws-amplify-scoping Feb 8, 2023
aws-eddy added a commit that referenced this pull request Feb 9, 2023
… analytics packages (#11945)

* chore: prepend @aws-amplify to amplify-category-function (#11923)

* chore: merging dev into feature branch (#11920)

* chore: migrate predictions category from inquirer to prompter

* fix: amplify-prompts import

* feat: revamp help command (#11667)

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command (resolving merge conflicts)

* feat: revamp help command (remove non-null assertions)

* feat: revamp help command (remove non-null assertions)

* feat: revamp help command (revisions)

* feat: revamp help command (revisions)

* feat: revamp help command (revisions)

* feat: revamp help command (update to use array find)

* feat: revamp help command (switch to single quotes)

* feat: revamp help command (switch to single quotes)

* feat: revamp help command (put imports on same line)

* feat: revamp help command (extract api)

* feat: revamp help command (prettier on help-helpers)

* feat: revamp help command (fix tag line)

* feat: revamp help command (changing test names)

* feat: revamp help command (refactoring preserveHelpInformation)

* chore: fix unit test for predictions prompter migration

* chore: fix delete project unit test for predictions prompter migration

* chore: added prompterAdapter class to handle prompt objects by type

* chore: updated migration tests to use a different version of push as prompter interaction changed in this PR

* chore: fix predictions e2e test as the new prompt will auto-select the single option

* chore: removed unused import

* chore: fixed codeQL warnings

* chore: fix migration tests using inquirer prompts

* chore: e2e tests affected by inquirer to prompts change

* chore: e2e tests affected by inquirer to prompts change

* chore: split log running tests

* chore: addressing PR feedback

* test: fix e2e test runAsync error validation

* chore: replaced static string literal as dynamic key with field name

* fix: modal windows test for opensearch simulator (#11911)

* fix: modal windows test for opensearch simulator

* fix: don't run opensearch-simulator test on windows

* feat: force version bump (#11913)

* chore: fix dependency versions and update clean command (#11915)

---------

Co-authored-by: Pavel Lazar <[email protected]>
Co-authored-by: lazpavel <[email protected]>
Co-authored-by: Zachary Goldberg <[email protected]>
Co-authored-by: Spencer Stolworthy <[email protected]>
Co-authored-by: John Hockett <[email protected]>

* merging dev into @aws-amplify-scoping (#11921)

* chore: migrate predictions category from inquirer to prompter

* fix: amplify-prompts import

* feat: revamp help command (#11667)

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command (resolving merge conflicts)

* feat: revamp help command (remove non-null assertions)

* feat: revamp help command (remove non-null assertions)

* feat: revamp help command (revisions)

* feat: revamp help command (revisions)

* feat: revamp help command (revisions)

* feat: revamp help command (update to use array find)

* feat: revamp help command (switch to single quotes)

* feat: revamp help command (switch to single quotes)

* feat: revamp help command (put imports on same line)

* feat: revamp help command (extract api)

* feat: revamp help command (prettier on help-helpers)

* feat: revamp help command (fix tag line)

* feat: revamp help command (changing test names)

* feat: revamp help command (refactoring preserveHelpInformation)

* chore: fix unit test for predictions prompter migration

* chore: fix delete project unit test for predictions prompter migration

* chore: added prompterAdapter class to handle prompt objects by type

* chore: updated migration tests to use a different version of push as prompter interaction changed in this PR

* chore: fix predictions e2e test as the new prompt will auto-select the single option

* chore: removed unused import

* chore: fixed codeQL warnings

* chore: fix migration tests using inquirer prompts

* chore: e2e tests affected by inquirer to prompts change

* chore: e2e tests affected by inquirer to prompts change

* chore: split log running tests

* chore: addressing PR feedback

* test: fix e2e test runAsync error validation

* chore: replaced static string literal as dynamic key with field name

* fix: modal windows test for opensearch simulator (#11911)

* fix: modal windows test for opensearch simulator

* fix: don't run opensearch-simulator test on windows

* feat: force version bump (#11913)

* chore: fix dependency versions and update clean command (#11915)

---------

Co-authored-by: Pavel Lazar <[email protected]>
Co-authored-by: lazpavel <[email protected]>
Co-authored-by: Zachary Goldberg <[email protected]>
Co-authored-by: Spencer Stolworthy <[email protected]>
Co-authored-by: John Hockett <[email protected]>

* chore: prepend @aws-amplify to amplify-category-function

* chore: yarn extract-api

---------

Co-authored-by: Pavel Lazar <[email protected]>
Co-authored-by: lazpavel <[email protected]>
Co-authored-by: Zachary Goldberg <[email protected]>
Co-authored-by: Spencer Stolworthy <[email protected]>
Co-authored-by: John Hockett <[email protected]>

* chore: prepend @aws-amplify to amplify-category-interactions (#11930)

* prepend @aws-amplify to amplify-categor-interactions

* chore: fixing yarn extract-api

* chore: prepend @aws-amplify to amplify-category-geo (#11926)

* chore: prepend @aws-amplify to amplify-category-geo

* chore: running yarn extract

* chore: fixing yarn extract-api

* chore: prepend @aws-amplify to amplify-category-analytics (#11922)

* adding aws-amplify to category analytics package

* chore: syncing with dev

* chore: fixing yarn.lock

* chore: yarn extract-api

* chore: fixing extract-api

* chore: prepend aws/amplify to amplify-category-hosting (#11929)

* chore: adding @aws-amplify to hosting category dep

* prepend aws-amplify for amplify hosting dependency

* chore: running yarn extract

* chore: fixing yarn extract-api

* fix: geo and notifications were not added to official plugin list

* chore: remove notifications from this PR

---------

Co-authored-by: Pavel Lazar <[email protected]>
Co-authored-by: lazpavel <[email protected]>
Co-authored-by: Zachary Goldberg <[email protected]>
Co-authored-by: Spencer Stolworthy <[email protected]>
Co-authored-by: John Hockett <[email protected]>
aws-eddy added a commit that referenced this pull request Feb 15, 2023
* chore: adding scoping for amplify-app

* adding dependency withing package.json

* chore: prepend @aws-amplify to amplify-category-function (#11923)

* chore: merging dev into feature branch (#11920)

* chore: migrate predictions category from inquirer to prompter

* fix: amplify-prompts import

* feat: revamp help command (#11667)

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command (resolving merge conflicts)

* feat: revamp help command (remove non-null assertions)

* feat: revamp help command (remove non-null assertions)

* feat: revamp help command (revisions)

* feat: revamp help command (revisions)

* feat: revamp help command (revisions)

* feat: revamp help command (update to use array find)

* feat: revamp help command (switch to single quotes)

* feat: revamp help command (switch to single quotes)

* feat: revamp help command (put imports on same line)

* feat: revamp help command (extract api)

* feat: revamp help command (prettier on help-helpers)

* feat: revamp help command (fix tag line)

* feat: revamp help command (changing test names)

* feat: revamp help command (refactoring preserveHelpInformation)

* chore: fix unit test for predictions prompter migration

* chore: fix delete project unit test for predictions prompter migration

* chore: added prompterAdapter class to handle prompt objects by type

* chore: updated migration tests to use a different version of push as prompter interaction changed in this PR

* chore: fix predictions e2e test as the new prompt will auto-select the single option

* chore: removed unused import

* chore: fixed codeQL warnings

* chore: fix migration tests using inquirer prompts

* chore: e2e tests affected by inquirer to prompts change

* chore: e2e tests affected by inquirer to prompts change

* chore: split log running tests

* chore: addressing PR feedback

* test: fix e2e test runAsync error validation

* chore: replaced static string literal as dynamic key with field name

* fix: modal windows test for opensearch simulator (#11911)

* fix: modal windows test for opensearch simulator

* fix: don't run opensearch-simulator test on windows

* feat: force version bump (#11913)

* chore: fix dependency versions and update clean command (#11915)

---------

Co-authored-by: Pavel Lazar <[email protected]>
Co-authored-by: lazpavel <[email protected]>
Co-authored-by: Zachary Goldberg <[email protected]>
Co-authored-by: Spencer Stolworthy <[email protected]>
Co-authored-by: John Hockett <[email protected]>

* merging dev into @aws-amplify-scoping (#11921)

* chore: migrate predictions category from inquirer to prompter

* fix: amplify-prompts import

* feat: revamp help command (#11667)

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command (resolving merge conflicts)

* feat: revamp help command (remove non-null assertions)

* feat: revamp help command (remove non-null assertions)

* feat: revamp help command (revisions)

* feat: revamp help command (revisions)

* feat: revamp help command (revisions)

* feat: revamp help command (update to use array find)

* feat: revamp help command (switch to single quotes)

* feat: revamp help command (switch to single quotes)

* feat: revamp help command (put imports on same line)

* feat: revamp help command (extract api)

* feat: revamp help command (prettier on help-helpers)

* feat: revamp help command (fix tag line)

* feat: revamp help command (changing test names)

* feat: revamp help command (refactoring preserveHelpInformation)

* chore: fix unit test for predictions prompter migration

* chore: fix delete project unit test for predictions prompter migration

* chore: added prompterAdapter class to handle prompt objects by type

* chore: updated migration tests to use a different version of push as prompter interaction changed in this PR

* chore: fix predictions e2e test as the new prompt will auto-select the single option

* chore: removed unused import

* chore: fixed codeQL warnings

* chore: fix migration tests using inquirer prompts

* chore: e2e tests affected by inquirer to prompts change

* chore: e2e tests affected by inquirer to prompts change

* chore: split log running tests

* chore: addressing PR feedback

* test: fix e2e test runAsync error validation

* chore: replaced static string literal as dynamic key with field name

* fix: modal windows test for opensearch simulator (#11911)

* fix: modal windows test for opensearch simulator

* fix: don't run opensearch-simulator test on windows

* feat: force version bump (#11913)

* chore: fix dependency versions and update clean command (#11915)

---------

Co-authored-by: Pavel Lazar <[email protected]>
Co-authored-by: lazpavel <[email protected]>
Co-authored-by: Zachary Goldberg <[email protected]>
Co-authored-by: Spencer Stolworthy <[email protected]>
Co-authored-by: John Hockett <[email protected]>

* chore: prepend @aws-amplify to amplify-category-function

* chore: yarn extract-api

---------

Co-authored-by: Pavel Lazar <[email protected]>
Co-authored-by: lazpavel <[email protected]>
Co-authored-by: Zachary Goldberg <[email protected]>
Co-authored-by: Spencer Stolworthy <[email protected]>
Co-authored-by: John Hockett <[email protected]>

* chore: prepend @aws-amplify to amplify-category-interactions (#11930)

* prepend @aws-amplify to amplify-categor-interactions

* chore: fixing yarn extract-api

* chore: prepend @aws-amplify to amplify-category-geo (#11926)

* chore: prepend @aws-amplify to amplify-category-geo

* chore: running yarn extract

* chore: fixing yarn extract-api

* chore: prepend @aws-amplify to amplify-category-analytics (#11922)

* adding aws-amplify to category analytics package

* chore: syncing with dev

* chore: fixing yarn.lock

* chore: yarn extract-api

* chore: fixing extract-api

* chore: prepend aws/amplify to amplify-category-hosting (#11929)

* chore: adding @aws-amplify to hosting category dep

* prepend aws-amplify for amplify hosting dependency

* chore: running yarn extract

* chore: fixing yarn extract-api

* chore: regenerate yarn.lockfile

---------

Co-authored-by: Pavel Lazar <[email protected]>
Co-authored-by: lazpavel <[email protected]>
Co-authored-by: Zachary Goldberg <[email protected]>
Co-authored-by: Spencer Stolworthy <[email protected]>
Co-authored-by: John Hockett <[email protected]>
aws-eddy added a commit that referenced this pull request Feb 20, 2023
* chore: adding scoping for amplify-app

* adding dependency withing package.json

* chore: prepend @aws-amplify to amplify-category-function (#11923)

* chore: merging dev into feature branch (#11920)

* chore: migrate predictions category from inquirer to prompter

* fix: amplify-prompts import

* feat: revamp help command (#11667)

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command (resolving merge conflicts)

* feat: revamp help command (remove non-null assertions)

* feat: revamp help command (remove non-null assertions)

* feat: revamp help command (revisions)

* feat: revamp help command (revisions)

* feat: revamp help command (revisions)

* feat: revamp help command (update to use array find)

* feat: revamp help command (switch to single quotes)

* feat: revamp help command (switch to single quotes)

* feat: revamp help command (put imports on same line)

* feat: revamp help command (extract api)

* feat: revamp help command (prettier on help-helpers)

* feat: revamp help command (fix tag line)

* feat: revamp help command (changing test names)

* feat: revamp help command (refactoring preserveHelpInformation)

* chore: fix unit test for predictions prompter migration

* chore: fix delete project unit test for predictions prompter migration

* chore: added prompterAdapter class to handle prompt objects by type

* chore: updated migration tests to use a different version of push as prompter interaction changed in this PR

* chore: fix predictions e2e test as the new prompt will auto-select the single option

* chore: removed unused import

* chore: fixed codeQL warnings

* chore: fix migration tests using inquirer prompts

* chore: e2e tests affected by inquirer to prompts change

* chore: e2e tests affected by inquirer to prompts change

* chore: split log running tests

* chore: addressing PR feedback

* test: fix e2e test runAsync error validation

* chore: replaced static string literal as dynamic key with field name

* fix: modal windows test for opensearch simulator (#11911)

* fix: modal windows test for opensearch simulator

* fix: don't run opensearch-simulator test on windows

* feat: force version bump (#11913)

* chore: fix dependency versions and update clean command (#11915)

---------

Co-authored-by: Pavel Lazar <[email protected]>
Co-authored-by: lazpavel <[email protected]>
Co-authored-by: Zachary Goldberg <[email protected]>
Co-authored-by: Spencer Stolworthy <[email protected]>
Co-authored-by: John Hockett <[email protected]>

* merging dev into @aws-amplify-scoping (#11921)

* chore: migrate predictions category from inquirer to prompter

* fix: amplify-prompts import

* feat: revamp help command (#11667)

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command (resolving merge conflicts)

* feat: revamp help command (remove non-null assertions)

* feat: revamp help command (remove non-null assertions)

* feat: revamp help command (revisions)

* feat: revamp help command (revisions)

* feat: revamp help command (revisions)

* feat: revamp help command (update to use array find)

* feat: revamp help command (switch to single quotes)

* feat: revamp help command (switch to single quotes)

* feat: revamp help command (put imports on same line)

* feat: revamp help command (extract api)

* feat: revamp help command (prettier on help-helpers)

* feat: revamp help command (fix tag line)

* feat: revamp help command (changing test names)

* feat: revamp help command (refactoring preserveHelpInformation)

* chore: fix unit test for predictions prompter migration

* chore: fix delete project unit test for predictions prompter migration

* chore: added prompterAdapter class to handle prompt objects by type

* chore: updated migration tests to use a different version of push as prompter interaction changed in this PR

* chore: fix predictions e2e test as the new prompt will auto-select the single option

* chore: removed unused import

* chore: fixed codeQL warnings

* chore: fix migration tests using inquirer prompts

* chore: e2e tests affected by inquirer to prompts change

* chore: e2e tests affected by inquirer to prompts change

* chore: split log running tests

* chore: addressing PR feedback

* test: fix e2e test runAsync error validation

* chore: replaced static string literal as dynamic key with field name

* fix: modal windows test for opensearch simulator (#11911)

* fix: modal windows test for opensearch simulator

* fix: don't run opensearch-simulator test on windows

* feat: force version bump (#11913)

* chore: fix dependency versions and update clean command (#11915)

---------

Co-authored-by: Pavel Lazar <[email protected]>
Co-authored-by: lazpavel <[email protected]>
Co-authored-by: Zachary Goldberg <[email protected]>
Co-authored-by: Spencer Stolworthy <[email protected]>
Co-authored-by: John Hockett <[email protected]>

* chore: prepend @aws-amplify to amplify-category-function

* chore: yarn extract-api

---------

Co-authored-by: Pavel Lazar <[email protected]>
Co-authored-by: lazpavel <[email protected]>
Co-authored-by: Zachary Goldberg <[email protected]>
Co-authored-by: Spencer Stolworthy <[email protected]>
Co-authored-by: John Hockett <[email protected]>

* chore: prepend @aws-amplify to amplify-category-interactions (#11930)

* prepend @aws-amplify to amplify-categor-interactions

* chore: fixing yarn extract-api

* chore: prepend @aws-amplify to amplify-category-geo (#11926)

* chore: prepend @aws-amplify to amplify-category-geo

* chore: running yarn extract

* chore: fixing yarn extract-api

* chore: prepend @aws-amplify to amplify-category-analytics (#11922)

* adding aws-amplify to category analytics package

* chore: syncing with dev

* chore: fixing yarn.lock

* chore: yarn extract-api

* chore: fixing extract-api

* chore: prepend aws/amplify to amplify-category-hosting (#11929)

* chore: adding @aws-amplify to hosting category dep

* prepend aws-amplify for amplify hosting dependency

* chore: running yarn extract

* chore: fixing yarn extract-api

* chore: regenerate yarn.lockfile

* chore: running prettier

* chore: sorting package.json

---------

Co-authored-by: Pavel Lazar <[email protected]>
Co-authored-by: lazpavel <[email protected]>
Co-authored-by: Zachary Goldberg <[email protected]>
Co-authored-by: Spencer Stolworthy <[email protected]>
Co-authored-by: John Hockett <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency-issue Issue with another dependency used
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants