-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: windows smoke test list #11797
Merged
Merged
ci: windows smoke test list #11797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdstolworthy
approved these changes
Jan 18, 2023
Comment on lines
+234
to
+235
const isNotDevBranch = process.env.CIRCLE_BRANCH !== 'dev'; | ||
if (isNotDevBranch && os === 'w' && !WINDOWS_SMOKE_TESTS.includes(test)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
const isNotDevBranch = process.env.CIRCLE_BRANCH !== 'dev'; | |
if (isNotDevBranch && os === 'w' && !WINDOWS_SMOKE_TESTS.includes(test)) { | |
const isDevBranch = process.env.CIRCLE_BRANCH === 'dev'; | |
if (!isDevBranch && os === 'w' && !WINDOWS_SMOKE_TESTS.includes(test)) { |
awsluja
commented
Jan 18, 2023
@@ -170,6 +230,11 @@ export const splitTestsV2 = function splitTests( | |||
if (TEST_EXCLUSIONS[os].find(excluded => test === excluded)) { | |||
continue; | |||
} | |||
// when we are not running E2E on 'dev', we only run a subset of tests on Windows | |||
const isNotDevBranch = process.env.CIRCLE_BRANCH !== 'dev'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jhockett
approved these changes
Jan 18, 2023
aws-eddy
added a commit
that referenced
this pull request
Jan 20, 2023
* chore: migrate custom category from inquirer to prompter library * chore: Replace inquirer with amplify-prompts in amplify-category-analytics package * fix: custom category prompter tests * refactor: clean up dependencies in package.json, update messaging in pinpoing-walktrhough, update e2e tests for kinesis and pinpoint prompts * chore: bump codegen version * test: update snapshot after codegen version change * chore: bump api category dependencies to @aws-amplify/[email protected] * fix: cfn ambda outputs when forcePush flag is used * fix: add to migration test list * fix: address comments * fix: removes git clone windows test * chore: removes redundant import * fix: revert windows test * fix: extract api call * fix: set NoEcho flag on OAuth creds CFN param * chore(release): Publish latest [ci skip] - [email protected] - @aws-amplify/[email protected] - [email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - @aws-amplify/[email protected] - [email protected] - [email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - [email protected] - @aws-amplify/[email protected] - [email protected] - [email protected] - [email protected] - @aws-amplify/[email protected] - [email protected] - @aws-amplify/[email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - @aws-amplify/[email protected] - [email protected] - [email protected] - @aws-amplify/[email protected] - [email protected] - [email protected] - [email protected] - @aws-amplify/[email protected] * ci: e2e multi-core optimizations (#11685) * ci: migrated to new test strategy * chore: add other tests and migration too * chore: cleanup * chore: cleanup * chore: cleanup unused e2e tests * chore: remove generated file * chore: remove parallelization blocker * chore: force parallel runs * chore: cleanup test list * chore: disable retries and cleanup exclusions * chore: bump test count to fill gaps * chore: move random id earlier in project name * chore: update yarn version * chore: fix typo * chore: try to fix delete issues * chore: fix teardown on delete error * ci: create custom file system mutex * chore: cleanup logs * ci: increase randomness of initial lock creation * chore: move migration tests to small isolated vms * chore: adjust concurrency * chore: update naming * ci: update reporter to better handle concurrent tests * ci: add use parent account exceptions * chore: cleanup naming, fix windows artifacts * chore: use data to optimize test scheduling * chore: cleanup * chore: cleanup * chore: fix call flow * chore: workaround duplicate spinner bugs * ci: split api_2 test * chore: increase push timeout * ci: add method to run solo tests * ci: configure retries compatible with worker pools * ci: workaround concurrent polling limits * chore: fix bug with solo tests * chore: move import & geo tests to run solo * chore: add artifact scripts * chore: trigger workflow results * ci: fix artifact path * chore: cleanup * chore: add timer spy * ci: update test lists * chore: cleanup * ci: fix retries * ci: move delays to createProjectDir * ci: use same script for e2e as linux on windows * chore: split storage-1 test * ci: fix config * ci: add bash env * ci: reduce timeout on push * ci: update test lists * ci: update test lists * ci: lower timeout and enable concurrent migration testing * ci: update test list * ci: restructure migration test setups * ci: cleanup to use file names instead of old job names * chore: refactor * ci: fix dependencies * ci: attempt to fix retry on windows * chore: revert retry changes * chore: undo changes to addCircleCiTags * chore: address PR feedback * chore: undo changes to spinners * chore: cleanup unused files * chore: lint & formatting * chore: lint, remove unused import * chore: undo changes to initialize-env.ts * chore: removed overly complicated and confusing logic in pinpoint walkthrough * ci: windows smoke test list (#11797) * ci: migrated to new test strategy * chore: add other tests and migration too * chore: cleanup * chore: cleanup * chore: cleanup unused e2e tests * chore: remove generated file * chore: remove parallelization blocker * chore: force parallel runs * chore: cleanup test list * chore: disable retries and cleanup exclusions * chore: bump test count to fill gaps * chore: move random id earlier in project name * chore: update yarn version * chore: fix typo * chore: try to fix delete issues * chore: fix teardown on delete error * ci: create custom file system mutex * chore: cleanup logs * ci: increase randomness of initial lock creation * chore: move migration tests to small isolated vms * chore: adjust concurrency * chore: update naming * ci: update reporter to better handle concurrent tests * ci: add use parent account exceptions * chore: cleanup naming, fix windows artifacts * chore: use data to optimize test scheduling * chore: cleanup * chore: cleanup * chore: fix call flow * chore: workaround duplicate spinner bugs * ci: split api_2 test * chore: increase push timeout * ci: add method to run solo tests * ci: configure retries compatible with worker pools * ci: workaround concurrent polling limits * chore: fix bug with solo tests * chore: move import & geo tests to run solo * chore: add artifact scripts * chore: trigger workflow results * ci: fix artifact path * chore: cleanup * chore: add timer spy * ci: update test lists * chore: cleanup * ci: fix retries * ci: move delays to createProjectDir * ci: use same script for e2e as linux on windows * chore: split storage-1 test * ci: fix config * ci: add bash env * ci: reduce timeout on push * ci: update test lists * ci: update test lists * ci: lower timeout and enable concurrent migration testing * ci: update test list * ci: restructure migration test setups * ci: cleanup to use file names instead of old job names * chore: refactor * ci: fix dependencies * ci: attempt to fix retry on windows * chore: revert retry changes * chore: undo changes to addCircleCiTags * chore: address PR feedback * chore: undo changes to spinners * chore: cleanup unused files * chore: lint & formatting * chore: lint, remove unused import * chore: undo changes to initialize-env.ts * ci: windows smoke test list for non-dev branches * chore: remove verify-api pre-push hook (#11799) * fix: remove production env variable from amplify script execution * fix: do not overload NODE_ENV env parameter for usage data filtering * fix: do not overload NODE_ENV env parameter for usage data filtering * fix: do not overload NODE_ENV env parameter for usage data filtering * fix: test timeouts on simulator tests (#11804) * ci: fix staleness filters (#11801) * ci: fix staleness filters * ci: only delete stale apps & stacks * chore: refactor * chore: migrate interactions category from inquirer to prompter library * fix: default values for interactions prompter * chore: addressed PR feedback * chore: addressed PR feedback * chore: Persist downstream exceptions in usage metrics (#11711) * chore: Persist downstream exceptions in usage metrics * fix variable name case * chore: Populate cfn exceptions messages in AmplifyFault (#11764) * chore: Persist cfn exceptions in usage metrics * Add a tab between different cfn error messages * refactor filtering the stacks with error * build(deps): bump json5 from 1.0.1 to 1.0.2 (#11697) Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ci: fix cleanup script throttling (#11716) * ci: update cleanup script to reduce throttling * chore: add extract api file * ci: fix condition * chore: cleanup * chore: add back logs * chore: move cleanup to start to avoid deleting apps while running * chore: update cleanup script * chore: revert build change * chore: fix md file * chore: cleanup * chore: address pr feedback * chore: comments * chore: refactor * chore: fix lint issues * chore: feature flag for Lazy Loading and Custom Selection Set support (#11566) * chore: feature flag for iOS LazyReference and ModelPath support * update FF naming * chore: add debug command to all e2e tests * fix: status command with --debug flag * feat: revamp help command (#11667) * feat: revamp help command * feat: revamp help command * feat: revamp help command * feat: revamp help command * feat: revamp help command * feat: revamp help command * feat: revamp help command (resolving merge conflicts) * feat: revamp help command (remove non-null assertions) * feat: revamp help command (remove non-null assertions) * feat: revamp help command (revisions) * feat: revamp help command (revisions) * feat: revamp help command (revisions) * feat: revamp help command (update to use array find) * feat: revamp help command (switch to single quotes) * feat: revamp help command (switch to single quotes) * feat: revamp help command (put imports on same line) * feat: revamp help command (extract api) * feat: revamp help command (prettier on help-helpers) * feat: revamp help command (fix tag line) * feat: revamp help command (changing test names) * feat: revamp help command (refactoring preserveHelpInformation) * fix(global-prefix): remove global-prefix package (#11408) * fix: update prepush hook to clean and rebuild before running verify extract api (#11753) * chore: add codeql scanning (#11518) * chore: add codeql scanning * fix: added quality scan to codeql * fix: make prompter multi-select indicator more distinct (#11742) * Convert back to async method * Add some method comments * fix type in the comments Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: awsluja <[email protected]> Co-authored-by: Michael Law <[email protected]> Co-authored-by: Pavel Lazar <[email protected]> Co-authored-by: Zachary Goldberg <[email protected]> Co-authored-by: MorCohenAres <[email protected]> Co-authored-by: Spencer Stolworthy <[email protected]> Co-authored-by: Edward Foyle <[email protected]> * chore: addressed PR feedback * chore: script to allow simple collection of coverage from all projects (#11798) * chore: add coverage collection script for local unit tests runs * fix: remove unused import * fix: updated dev dependencies * fix: added file level doc, filtered out unwanted coverage on e2e, lib, and test files * fix: more descriptive filename for the script * chore: addressed PR feedback * fix: prompt string to match e2e (#11816) Co-authored-by: Akshay Upadhyay <[email protected]> * chore: correctly filter failed cfn events for displaying error messages (#11815) * chore: do not filter AWS::CloudFormation::Stack type failure events if they have valid error message * Update packages/amplify-provider-awscloudformation/src/aws-utils/aws-cfn.js Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Pavel Lazar <[email protected]> Co-authored-by: kuhlmanp <[email protected]> Co-authored-by: phani-srikar <[email protected]> Co-authored-by: Al Harris <[email protected]> Co-authored-by: Akshay Upadhyay <[email protected]> Co-authored-by: Edward Foyle <[email protected]> Co-authored-by: aws-amplify-bot <[email protected]> Co-authored-by: Pavel Lazar <[email protected]> Co-authored-by: Danielle Adams <[email protected]> Co-authored-by: awsluja <[email protected]> Co-authored-by: Spencer Stolworthy <[email protected]> Co-authored-by: Amplifiyer <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michael Law <[email protected]> Co-authored-by: Zachary Goldberg <[email protected]> Co-authored-by: MorCohenAres <[email protected]> Co-authored-by: Spencer Stolworthy <[email protected]> Co-authored-by: akshbhu <[email protected]>
aws-eddy
added a commit
that referenced
this pull request
Jan 23, 2023
* chore: migrate custom category from inquirer to prompter library * chore: Replace inquirer with amplify-prompts in amplify-category-analytics package * fix: custom category prompter tests * refactor: clean up dependencies in package.json, update messaging in pinpoing-walktrhough, update e2e tests for kinesis and pinpoint prompts * chore: bump codegen version * test: update snapshot after codegen version change * chore: bump api category dependencies to @aws-amplify/[email protected] * fix: cfn ambda outputs when forcePush flag is used * fix: add to migration test list * fix: address comments * fix: removes git clone windows test * chore: removes redundant import * fix: revert windows test * fix: extract api call * fix: set NoEcho flag on OAuth creds CFN param * chore(release): Publish latest [ci skip] - [email protected] - @aws-amplify/[email protected] - [email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - @aws-amplify/[email protected] - [email protected] - [email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - [email protected] - @aws-amplify/[email protected] - [email protected] - [email protected] - [email protected] - @aws-amplify/[email protected] - [email protected] - @aws-amplify/[email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - @aws-amplify/[email protected] - [email protected] - [email protected] - @aws-amplify/[email protected] - [email protected] - [email protected] - [email protected] - @aws-amplify/[email protected] * ci: e2e multi-core optimizations (#11685) * ci: migrated to new test strategy * chore: add other tests and migration too * chore: cleanup * chore: cleanup * chore: cleanup unused e2e tests * chore: remove generated file * chore: remove parallelization blocker * chore: force parallel runs * chore: cleanup test list * chore: disable retries and cleanup exclusions * chore: bump test count to fill gaps * chore: move random id earlier in project name * chore: update yarn version * chore: fix typo * chore: try to fix delete issues * chore: fix teardown on delete error * ci: create custom file system mutex * chore: cleanup logs * ci: increase randomness of initial lock creation * chore: move migration tests to small isolated vms * chore: adjust concurrency * chore: update naming * ci: update reporter to better handle concurrent tests * ci: add use parent account exceptions * chore: cleanup naming, fix windows artifacts * chore: use data to optimize test scheduling * chore: cleanup * chore: cleanup * chore: fix call flow * chore: workaround duplicate spinner bugs * ci: split api_2 test * chore: increase push timeout * ci: add method to run solo tests * ci: configure retries compatible with worker pools * ci: workaround concurrent polling limits * chore: fix bug with solo tests * chore: move import & geo tests to run solo * chore: add artifact scripts * chore: trigger workflow results * ci: fix artifact path * chore: cleanup * chore: add timer spy * ci: update test lists * chore: cleanup * ci: fix retries * ci: move delays to createProjectDir * ci: use same script for e2e as linux on windows * chore: split storage-1 test * ci: fix config * ci: add bash env * ci: reduce timeout on push * ci: update test lists * ci: update test lists * ci: lower timeout and enable concurrent migration testing * ci: update test list * ci: restructure migration test setups * ci: cleanup to use file names instead of old job names * chore: refactor * ci: fix dependencies * ci: attempt to fix retry on windows * chore: revert retry changes * chore: undo changes to addCircleCiTags * chore: address PR feedback * chore: undo changes to spinners * chore: cleanup unused files * chore: lint & formatting * chore: lint, remove unused import * chore: undo changes to initialize-env.ts * chore: removed overly complicated and confusing logic in pinpoint walkthrough * ci: windows smoke test list (#11797) * ci: migrated to new test strategy * chore: add other tests and migration too * chore: cleanup * chore: cleanup * chore: cleanup unused e2e tests * chore: remove generated file * chore: remove parallelization blocker * chore: force parallel runs * chore: cleanup test list * chore: disable retries and cleanup exclusions * chore: bump test count to fill gaps * chore: move random id earlier in project name * chore: update yarn version * chore: fix typo * chore: try to fix delete issues * chore: fix teardown on delete error * ci: create custom file system mutex * chore: cleanup logs * ci: increase randomness of initial lock creation * chore: move migration tests to small isolated vms * chore: adjust concurrency * chore: update naming * ci: update reporter to better handle concurrent tests * ci: add use parent account exceptions * chore: cleanup naming, fix windows artifacts * chore: use data to optimize test scheduling * chore: cleanup * chore: cleanup * chore: fix call flow * chore: workaround duplicate spinner bugs * ci: split api_2 test * chore: increase push timeout * ci: add method to run solo tests * ci: configure retries compatible with worker pools * ci: workaround concurrent polling limits * chore: fix bug with solo tests * chore: move import & geo tests to run solo * chore: add artifact scripts * chore: trigger workflow results * ci: fix artifact path * chore: cleanup * chore: add timer spy * ci: update test lists * chore: cleanup * ci: fix retries * ci: move delays to createProjectDir * ci: use same script for e2e as linux on windows * chore: split storage-1 test * ci: fix config * ci: add bash env * ci: reduce timeout on push * ci: update test lists * ci: update test lists * ci: lower timeout and enable concurrent migration testing * ci: update test list * ci: restructure migration test setups * ci: cleanup to use file names instead of old job names * chore: refactor * ci: fix dependencies * ci: attempt to fix retry on windows * chore: revert retry changes * chore: undo changes to addCircleCiTags * chore: address PR feedback * chore: undo changes to spinners * chore: cleanup unused files * chore: lint & formatting * chore: lint, remove unused import * chore: undo changes to initialize-env.ts * ci: windows smoke test list for non-dev branches * chore: remove verify-api pre-push hook (#11799) * fix: remove production env variable from amplify script execution * fix: do not overload NODE_ENV env parameter for usage data filtering * fix: do not overload NODE_ENV env parameter for usage data filtering * fix: do not overload NODE_ENV env parameter for usage data filtering * fix: test timeouts on simulator tests (#11804) * ci: fix staleness filters (#11801) * ci: fix staleness filters * ci: only delete stale apps & stacks * chore: refactor * chore: migrate interactions category from inquirer to prompter library * fix: default values for interactions prompter * chore: addressed PR feedback * chore: addressed PR feedback * chore: Persist downstream exceptions in usage metrics (#11711) * chore: Persist downstream exceptions in usage metrics * fix variable name case * chore: Populate cfn exceptions messages in AmplifyFault (#11764) * chore: Persist cfn exceptions in usage metrics * Add a tab between different cfn error messages * refactor filtering the stacks with error * build(deps): bump json5 from 1.0.1 to 1.0.2 (#11697) Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ci: fix cleanup script throttling (#11716) * ci: update cleanup script to reduce throttling * chore: add extract api file * ci: fix condition * chore: cleanup * chore: add back logs * chore: move cleanup to start to avoid deleting apps while running * chore: update cleanup script * chore: revert build change * chore: fix md file * chore: cleanup * chore: address pr feedback * chore: comments * chore: refactor * chore: fix lint issues * chore: feature flag for Lazy Loading and Custom Selection Set support (#11566) * chore: feature flag for iOS LazyReference and ModelPath support * update FF naming * chore: add debug command to all e2e tests * fix: status command with --debug flag * feat: revamp help command (#11667) * feat: revamp help command * feat: revamp help command * feat: revamp help command * feat: revamp help command * feat: revamp help command * feat: revamp help command * feat: revamp help command (resolving merge conflicts) * feat: revamp help command (remove non-null assertions) * feat: revamp help command (remove non-null assertions) * feat: revamp help command (revisions) * feat: revamp help command (revisions) * feat: revamp help command (revisions) * feat: revamp help command (update to use array find) * feat: revamp help command (switch to single quotes) * feat: revamp help command (switch to single quotes) * feat: revamp help command (put imports on same line) * feat: revamp help command (extract api) * feat: revamp help command (prettier on help-helpers) * feat: revamp help command (fix tag line) * feat: revamp help command (changing test names) * feat: revamp help command (refactoring preserveHelpInformation) * fix(global-prefix): remove global-prefix package (#11408) * fix: update prepush hook to clean and rebuild before running verify extract api (#11753) * chore: add codeql scanning (#11518) * chore: add codeql scanning * fix: added quality scan to codeql * fix: make prompter multi-select indicator more distinct (#11742) * Convert back to async method * Add some method comments * fix type in the comments Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: awsluja <[email protected]> Co-authored-by: Michael Law <[email protected]> Co-authored-by: Pavel Lazar <[email protected]> Co-authored-by: Zachary Goldberg <[email protected]> Co-authored-by: MorCohenAres <[email protected]> Co-authored-by: Spencer Stolworthy <[email protected]> Co-authored-by: Edward Foyle <[email protected]> * chore: addressed PR feedback * chore: script to allow simple collection of coverage from all projects (#11798) * chore: add coverage collection script for local unit tests runs * fix: remove unused import * fix: updated dev dependencies * fix: added file level doc, filtered out unwanted coverage on e2e, lib, and test files * fix: more descriptive filename for the script * chore: addressed PR feedback * fix: prompt string to match e2e (#11816) Co-authored-by: Akshay Upadhyay <[email protected]> * chore: correctly filter failed cfn events for displaying error messages (#11815) * chore: do not filter AWS::CloudFormation::Stack type failure events if they have valid error message * Update packages/amplify-provider-awscloudformation/src/aws-utils/aws-cfn.js Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Pavel Lazar <[email protected]> Co-authored-by: kuhlmanp <[email protected]> Co-authored-by: phani-srikar <[email protected]> Co-authored-by: Al Harris <[email protected]> Co-authored-by: Akshay Upadhyay <[email protected]> Co-authored-by: Edward Foyle <[email protected]> Co-authored-by: aws-amplify-bot <[email protected]> Co-authored-by: Pavel Lazar <[email protected]> Co-authored-by: Danielle Adams <[email protected]> Co-authored-by: awsluja <[email protected]> Co-authored-by: Spencer Stolworthy <[email protected]> Co-authored-by: Amplifiyer <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michael Law <[email protected]> Co-authored-by: Zachary Goldberg <[email protected]> Co-authored-by: MorCohenAres <[email protected]> Co-authored-by: Spencer Stolworthy <[email protected]> Co-authored-by: akshbhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This change updates our E2E so that only a subset of windows tests run on PRs/E2E, but full E2E will still run for windows tests on 'dev'.
This generates 10 windows jobs that run ~30 tests.
E2e link:
https://app.circleci.com/pipelines/github/aws-amplify/amplify-cli/14737/workflows/747718cc-b0b1-43f8-b645-6d569f3f215b
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.