Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix cleanup script throttling #11716

Merged
merged 15 commits into from
Jan 10, 2023
Merged

ci: fix cleanup script throttling #11716

merged 15 commits into from
Jan 10, 2023

Conversation

awsluja
Copy link
Contributor

@awsluja awsluja commented Jan 5, 2023 •
edited
Loading

Description of changes

Currently, the cleanup script is not using the appropriate pagination & page limits to avoid throttling, which leads to exiting early without cleaning up resources.
Also, some resources don't get tagged with the Circle CI job tags, but should be deleted anyway (resource names that include "test" or "amplify-...-test".
Additionally, us-east-1 is not enabled on 'parent', so it throws an error which prevents other regions on that account from being cleaned up.

Solution:
Page sizes have have been reduced, so that batches are limited within a 60 second internal.
The cleanup script will now run 5 times with 60 seconds between each batch.

A fix has also been introduced to allow 'parent' to cleanup other regions even though us-east-1 is not enabled on that account.

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

awsluja
awsluja commented Jan 9, 2023
View reviewed changes
packages/amplify-e2e-tests/src/cleanup-e2e-resources.ts
const stackStatusFilter = [
'CREATE_COMPLETE',
'ROLLBACK_FAILED',
'ROLLBACK_COMPLETE',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added this, which was missing (Rollback_Complete)

@awsluja awsluja changed the title ci: DRAFT fix cleanup script throttling pt 1 ci: fix cleanup script throttling Jan 9, 2023
@awsluja awsluja marked this pull request as ready for review January 9, 2023 21:55
@awsluja awsluja requested a review from a team as a code owner January 9, 2023 21:55
awsluja
awsluja commented Jan 9, 2023
View reviewed changes
packages/amplify-e2e-tests/src/cleanup-e2e-resources.ts
// we'll only wait up to 10 minutes before moving on
await cfnClient.waitFor('stackDeleteComplete', { StackName: stackName, $waiter: { maxAttempts: 20 } }).promise();
// we'll only wait up to a minute before moving on
await cfnClient.waitFor('stackDeleteComplete', { StackName: stackName, $waiter: { maxAttempts: 2 } }).promise();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that this works even when lowered to just 30 seconds

sdstolworthy
sdstolworthy previously approved these changes Jan 9, 2023
View reviewed changes
packages/amplify-e2e-tests/src/cleanup-e2e-resources.ts
@@ -859,9 +942,18 @@ const cleanup = async (): Promise<void> => {

const filterPredicate = getFilterPredicate(args);
const accounts = await getAccountsToCleanup();

await Promise.all(accounts.map((account, i) => cleanupAccount(account, i, filterPredicate)));
for(let i = 0 ;i < 5; i ++){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great, but just fyi the package tiny-async-pool is already a dependency and does some neat stuff with async generators to make this more succinct and efficient. https://www.npmjs.com/package/tiny-async-pool. It's a nit, but it might shave a few minutes off of this.

@awsluja awsluja merged commit 7eb6669 into aws-amplify:dev Jan 10, 2023
Amplifiyer pushed a commit to Amplifiyer/amplify-cli that referenced this pull request Jan 13, 2023
@awsluja @Amplifiyer
ci: fix cleanup script throttling (aws-amplify#11716)
b34f2ea 
* ci: update cleanup script to reduce throttling

* chore: add extract api file

* ci: fix condition

* chore: cleanup

* chore: add back logs

* chore: move cleanup to start to avoid deleting apps while running

* chore: update cleanup script

* chore: revert build change

* chore: fix md file

* chore: cleanup

* chore: address pr feedback

* chore: comments

* chore: refactor

* chore: fix lint issues
akshbhu pushed a commit that referenced this pull request Jan 19, 2023
@Amplifiyer @dependabot
@awsluja @lawmicha @lazpavel @goldbez @MorCohenAres @sdstolworthy @edwardfoyle
chore: Populate cfn exceptions messages in AmplifyFault (#11764)
e6278b5 
* chore: Persist cfn exceptions in usage metrics

* Add a tab between different cfn error messages

* refactor filtering the stacks with error

* build(deps): bump json5 from 1.0.1 to 1.0.2 (#11697)

Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ci: fix cleanup script throttling (#11716)

* ci: update cleanup script to reduce throttling

* chore: add extract api file

* ci: fix condition

* chore: cleanup

* chore: add back logs

* chore: move cleanup to start to avoid deleting apps while running

* chore: update cleanup script

* chore: revert build change

* chore: fix md file

* chore: cleanup

* chore: address pr feedback

* chore: comments

* chore: refactor

* chore: fix lint issues

* chore: feature flag for Lazy Loading and Custom Selection Set support (#11566)

* chore: feature flag for iOS LazyReference and ModelPath support

* update FF naming

* chore: add debug command to all e2e tests

* fix: status command with --debug flag

* feat: revamp help command (#11667)

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command (resolving merge conflicts)

* feat: revamp help command (remove non-null assertions)

* feat: revamp help command (remove non-null assertions)

* feat: revamp help command (revisions)

* feat: revamp help command (revisions)

* feat: revamp help command (revisions)

* feat: revamp help command (update to use array find)

* feat: revamp help command (switch to single quotes)

* feat: revamp help command (switch to single quotes)

* feat: revamp help command (put imports on same line)

* feat: revamp help command (extract api)

* feat: revamp help command (prettier on help-helpers)

* feat: revamp help command (fix tag line)

* feat: revamp help command (changing test names)

* feat: revamp help command (refactoring preserveHelpInformation)

* fix(global-prefix): remove global-prefix package (#11408)

* fix: update prepush hook to clean and rebuild before running verify extract api (#11753)

* chore: add codeql scanning (#11518)

* chore: add codeql scanning

* fix: added quality scan to codeql

* fix: make prompter multi-select indicator more distinct (#11742)

* Convert back to async method

* Add some method comments

* fix type in the comments

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: awsluja <[email protected]>
Co-authored-by: Michael Law <[email protected]>
Co-authored-by: Pavel Lazar <[email protected]>
Co-authored-by: Zachary Goldberg <[email protected]>
Co-authored-by: MorCohenAres <[email protected]>
Co-authored-by: Spencer Stolworthy <[email protected]>
Co-authored-by: Edward Foyle <[email protected]>
aws-eddy added a commit that referenced this pull request Jan 20, 2023
@aws-eddy @lazpavel
@kuhlmanp @phani-srikar @alharris-at @edwardfoyle @danielleadams @awsluja @sdstolworthy @Amplifiyer @dependabot @lawmicha @goldbez @MorCohenAres @akshbhu
merging dev into feature branch (#11820)
d5063d8 
* chore: migrate custom category from inquirer to prompter library

* chore: Replace inquirer with amplify-prompts in amplify-category-analytics package

* fix: custom category prompter tests

* refactor: clean up dependencies in package.json, update messaging in pinpoing-walktrhough, update e2e tests for kinesis and pinpoint prompts

* chore: bump codegen version

* test: update snapshot after codegen version change

* chore: bump api category dependencies to @aws-amplify/[email protected]

* fix:  cfn ambda outputs when forcePush flag is used

* fix: add to migration test list

* fix: address comments

* fix: removes git clone windows test

* chore: removes redundant import

* fix: revert windows test

* fix: extract api call

* fix: set NoEcho flag on OAuth creds CFN param

* chore(release): Publish latest [ci skip]

 - [email protected]
 - @aws-amplify/[email protected]
 - [email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - @aws-amplify/[email protected]
 - [email protected]
 - [email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - [email protected]
 - @aws-amplify/[email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - @aws-amplify/[email protected]
 - [email protected]
 - @aws-amplify/[email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - @aws-amplify/[email protected]
 - [email protected]
 - [email protected]
 - @aws-amplify/[email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - @aws-amplify/[email protected]

* ci: e2e multi-core optimizations (#11685)

* ci: migrated to new test strategy

* chore: add other tests and migration too

* chore: cleanup

* chore: cleanup

* chore: cleanup unused e2e tests

* chore: remove generated file

* chore: remove parallelization blocker

* chore: force parallel runs

* chore: cleanup test list

* chore: disable retries and cleanup exclusions

* chore: bump test count to fill gaps

* chore: move random id earlier in project name

* chore: update yarn version

* chore: fix typo

* chore: try to fix delete issues

* chore: fix teardown on delete error

* ci: create custom file system mutex

* chore: cleanup logs

* ci: increase randomness of initial lock creation

* chore: move migration tests to small isolated vms

* chore: adjust concurrency

* chore: update naming

* ci: update reporter to better handle concurrent tests

* ci: add use parent account exceptions

* chore: cleanup naming, fix windows artifacts

* chore: use data to optimize test scheduling

* chore: cleanup

* chore: cleanup

* chore: fix call flow

* chore: workaround duplicate spinner bugs

* ci: split api_2 test

* chore: increase push timeout

* ci: add method to run solo tests

* ci: configure retries compatible with worker pools

* ci: workaround concurrent polling limits

* chore: fix bug with solo tests

* chore: move import & geo tests to run solo

* chore: add artifact scripts

* chore: trigger workflow results

* ci: fix artifact path

* chore: cleanup

* chore: add timer spy

* ci: update test lists

* chore: cleanup

* ci: fix retries

* ci: move delays to createProjectDir

* ci: use same script for e2e as linux on windows

* chore: split storage-1 test

* ci: fix config

* ci: add bash env

* ci: reduce timeout on push

* ci: update test lists

* ci: update test lists

* ci: lower timeout and enable concurrent migration testing

* ci: update test list

* ci: restructure migration test setups

* ci: cleanup to use file names instead of old job names

* chore: refactor

* ci: fix dependencies

* ci: attempt to fix retry on windows

* chore: revert retry changes

* chore: undo changes to addCircleCiTags

* chore: address PR feedback

* chore: undo changes to spinners

* chore: cleanup unused files

* chore: lint & formatting

* chore: lint, remove unused import

* chore: undo changes to initialize-env.ts

* chore: removed overly complicated and confusing logic in pinpoint walkthrough

* ci: windows smoke test list (#11797)

* ci: migrated to new test strategy

* chore: add other tests and migration too

* chore: cleanup

* chore: cleanup

* chore: cleanup unused e2e tests

* chore: remove generated file

* chore: remove parallelization blocker

* chore: force parallel runs

* chore: cleanup test list

* chore: disable retries and cleanup exclusions

* chore: bump test count to fill gaps

* chore: move random id earlier in project name

* chore: update yarn version

* chore: fix typo

* chore: try to fix delete issues

* chore: fix teardown on delete error

* ci: create custom file system mutex

* chore: cleanup logs

* ci: increase randomness of initial lock creation

* chore: move migration tests to small isolated vms

* chore: adjust concurrency

* chore: update naming

* ci: update reporter to better handle concurrent tests

* ci: add use parent account exceptions

* chore: cleanup naming, fix windows artifacts

* chore: use data to optimize test scheduling

* chore: cleanup

* chore: cleanup

* chore: fix call flow

* chore: workaround duplicate spinner bugs

* ci: split api_2 test

* chore: increase push timeout

* ci: add method to run solo tests

* ci: configure retries compatible with worker pools

* ci: workaround concurrent polling limits

* chore: fix bug with solo tests

* chore: move import & geo tests to run solo

* chore: add artifact scripts

* chore: trigger workflow results

* ci: fix artifact path

* chore: cleanup

* chore: add timer spy

* ci: update test lists

* chore: cleanup

* ci: fix retries

* ci: move delays to createProjectDir

* ci: use same script for e2e as linux on windows

* chore: split storage-1 test

* ci: fix config

* ci: add bash env

* ci: reduce timeout on push

* ci: update test lists

* ci: update test lists

* ci: lower timeout and enable concurrent migration testing

* ci: update test list

* ci: restructure migration test setups

* ci: cleanup to use file names instead of old job names

* chore: refactor

* ci: fix dependencies

* ci: attempt to fix retry on windows

* chore: revert retry changes

* chore: undo changes to addCircleCiTags

* chore: address PR feedback

* chore: undo changes to spinners

* chore: cleanup unused files

* chore: lint & formatting

* chore: lint, remove unused import

* chore: undo changes to initialize-env.ts

* ci: windows smoke test list for non-dev branches

* chore: remove verify-api pre-push hook (#11799)

* fix: remove production env variable from amplify script execution

* fix: do not overload NODE_ENV env parameter for usage data filtering

* fix: do not overload NODE_ENV env parameter for usage data filtering

* fix: do not overload NODE_ENV env parameter for usage data filtering

* fix: test timeouts on simulator tests (#11804)

* ci: fix staleness filters (#11801)

* ci: fix staleness filters

* ci: only delete stale apps & stacks

* chore: refactor

* chore: migrate interactions category from inquirer to prompter library

* fix: default values for interactions prompter

* chore: addressed PR feedback

* chore: addressed PR feedback

* chore: Persist downstream exceptions in usage metrics (#11711)

* chore: Persist downstream exceptions in usage metrics

* fix variable name case

* chore: Populate cfn exceptions messages in AmplifyFault (#11764)

* chore: Persist cfn exceptions in usage metrics

* Add a tab between different cfn error messages

* refactor filtering the stacks with error

* build(deps): bump json5 from 1.0.1 to 1.0.2 (#11697)

Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ci: fix cleanup script throttling (#11716)

* ci: update cleanup script to reduce throttling

* chore: add extract api file

* ci: fix condition

* chore: cleanup

* chore: add back logs

* chore: move cleanup to start to avoid deleting apps while running

* chore: update cleanup script

* chore: revert build change

* chore: fix md file

* chore: cleanup

* chore: address pr feedback

* chore: comments

* chore: refactor

* chore: fix lint issues

* chore: feature flag for Lazy Loading and Custom Selection Set support (#11566)

* chore: feature flag for iOS LazyReference and ModelPath support

* update FF naming

* chore: add debug command to all e2e tests

* fix: status command with --debug flag

* feat: revamp help command (#11667)

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command (resolving merge conflicts)

* feat: revamp help command (remove non-null assertions)

* feat: revamp help command (remove non-null assertions)

* feat: revamp help command (revisions)

* feat: revamp help command (revisions)

* feat: revamp help command (revisions)

* feat: revamp help command (update to use array find)

* feat: revamp help command (switch to single quotes)

* feat: revamp help command (switch to single quotes)

* feat: revamp help command (put imports on same line)

* feat: revamp help command (extract api)

* feat: revamp help command (prettier on help-helpers)

* feat: revamp help command (fix tag line)

* feat: revamp help command (changing test names)

* feat: revamp help command (refactoring preserveHelpInformation)

* fix(global-prefix): remove global-prefix package (#11408)

* fix: update prepush hook to clean and rebuild before running verify extract api (#11753)

* chore: add codeql scanning (#11518)

* chore: add codeql scanning

* fix: added quality scan to codeql

* fix: make prompter multi-select indicator more distinct (#11742)

* Convert back to async method

* Add some method comments

* fix type in the comments

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: awsluja <[email protected]>
Co-authored-by: Michael Law <[email protected]>
Co-authored-by: Pavel Lazar <[email protected]>
Co-authored-by: Zachary Goldberg <[email protected]>
Co-authored-by: MorCohenAres <[email protected]>
Co-authored-by: Spencer Stolworthy <[email protected]>
Co-authored-by: Edward Foyle <[email protected]>

* chore: addressed PR feedback

* chore: script to allow simple collection of coverage from all projects (#11798)

* chore: add coverage collection script for local unit tests runs

* fix: remove unused import

* fix: updated dev dependencies

* fix: added file level doc, filtered out unwanted coverage on e2e, lib, and test files

* fix: more descriptive filename for the script

* chore: addressed PR feedback

* fix: prompt string to match e2e (#11816)

Co-authored-by: Akshay Upadhyay <[email protected]>

* chore: correctly filter failed cfn events for displaying error messages (#11815)

* chore: do not filter AWS::CloudFormation::Stack type failure events if they have valid error message

* Update packages/amplify-provider-awscloudformation/src/aws-utils/aws-cfn.js

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Pavel Lazar <[email protected]>
Co-authored-by: kuhlmanp <[email protected]>
Co-authored-by: phani-srikar <[email protected]>
Co-authored-by: Al Harris <[email protected]>
Co-authored-by: Akshay Upadhyay <[email protected]>
Co-authored-by: Edward Foyle <[email protected]>
Co-authored-by: aws-amplify-bot <[email protected]>
Co-authored-by: Pavel Lazar <[email protected]>
Co-authored-by: Danielle Adams <[email protected]>
Co-authored-by: awsluja <[email protected]>
Co-authored-by: Spencer Stolworthy <[email protected]>
Co-authored-by: Amplifiyer <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Michael Law <[email protected]>
Co-authored-by: Zachary Goldberg <[email protected]>
Co-authored-by: MorCohenAres <[email protected]>
Co-authored-by: Spencer Stolworthy <[email protected]>
Co-authored-by: akshbhu <[email protected]>
aws-eddy added a commit that referenced this pull request Jan 23, 2023
@aws-eddy @lazpavel
@kuhlmanp @phani-srikar @alharris-at @edwardfoyle @danielleadams @awsluja @sdstolworthy @Amplifiyer @dependabot @lawmicha @goldbez @MorCohenAres @akshbhu
merging dev into feature branch (#11827)
ffbf770 
* chore: migrate custom category from inquirer to prompter library

* chore: Replace inquirer with amplify-prompts in amplify-category-analytics package

* fix: custom category prompter tests

* refactor: clean up dependencies in package.json, update messaging in pinpoing-walktrhough, update e2e tests for kinesis and pinpoint prompts

* chore: bump codegen version

* test: update snapshot after codegen version change

* chore: bump api category dependencies to @aws-amplify/[email protected]

* fix:  cfn ambda outputs when forcePush flag is used

* fix: add to migration test list

* fix: address comments

* fix: removes git clone windows test

* chore: removes redundant import

* fix: revert windows test

* fix: extract api call

* fix: set NoEcho flag on OAuth creds CFN param

* chore(release): Publish latest [ci skip]

 - [email protected]
 - @aws-amplify/[email protected]
 - [email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - @aws-amplify/[email protected]
 - [email protected]
 - [email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - [email protected]
 - @aws-amplify/[email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - @aws-amplify/[email protected]
 - [email protected]
 - @aws-amplify/[email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - @aws-amplify/[email protected]
 - [email protected]
 - [email protected]
 - @aws-amplify/[email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - @aws-amplify/[email protected]

* ci: e2e multi-core optimizations (#11685)

* ci: migrated to new test strategy

* chore: add other tests and migration too

* chore: cleanup

* chore: cleanup

* chore: cleanup unused e2e tests

* chore: remove generated file

* chore: remove parallelization blocker

* chore: force parallel runs

* chore: cleanup test list

* chore: disable retries and cleanup exclusions

* chore: bump test count to fill gaps

* chore: move random id earlier in project name

* chore: update yarn version

* chore: fix typo

* chore: try to fix delete issues

* chore: fix teardown on delete error

* ci: create custom file system mutex

* chore: cleanup logs

* ci: increase randomness of initial lock creation

* chore: move migration tests to small isolated vms

* chore: adjust concurrency

* chore: update naming

* ci: update reporter to better handle concurrent tests

* ci: add use parent account exceptions

* chore: cleanup naming, fix windows artifacts

* chore: use data to optimize test scheduling

* chore: cleanup

* chore: cleanup

* chore: fix call flow

* chore: workaround duplicate spinner bugs

* ci: split api_2 test

* chore: increase push timeout

* ci: add method to run solo tests

* ci: configure retries compatible with worker pools

* ci: workaround concurrent polling limits

* chore: fix bug with solo tests

* chore: move import & geo tests to run solo

* chore: add artifact scripts

* chore: trigger workflow results

* ci: fix artifact path

* chore: cleanup

* chore: add timer spy

* ci: update test lists

* chore: cleanup

* ci: fix retries

* ci: move delays to createProjectDir

* ci: use same script for e2e as linux on windows

* chore: split storage-1 test

* ci: fix config

* ci: add bash env

* ci: reduce timeout on push

* ci: update test lists

* ci: update test lists

* ci: lower timeout and enable concurrent migration testing

* ci: update test list

* ci: restructure migration test setups

* ci: cleanup to use file names instead of old job names

* chore: refactor

* ci: fix dependencies

* ci: attempt to fix retry on windows

* chore: revert retry changes

* chore: undo changes to addCircleCiTags

* chore: address PR feedback

* chore: undo changes to spinners

* chore: cleanup unused files

* chore: lint & formatting

* chore: lint, remove unused import

* chore: undo changes to initialize-env.ts

* chore: removed overly complicated and confusing logic in pinpoint walkthrough

* ci: windows smoke test list (#11797)

* ci: migrated to new test strategy

* chore: add other tests and migration too

* chore: cleanup

* chore: cleanup

* chore: cleanup unused e2e tests

* chore: remove generated file

* chore: remove parallelization blocker

* chore: force parallel runs

* chore: cleanup test list

* chore: disable retries and cleanup exclusions

* chore: bump test count to fill gaps

* chore: move random id earlier in project name

* chore: update yarn version

* chore: fix typo

* chore: try to fix delete issues

* chore: fix teardown on delete error

* ci: create custom file system mutex

* chore: cleanup logs

* ci: increase randomness of initial lock creation

* chore: move migration tests to small isolated vms

* chore: adjust concurrency

* chore: update naming

* ci: update reporter to better handle concurrent tests

* ci: add use parent account exceptions

* chore: cleanup naming, fix windows artifacts

* chore: use data to optimize test scheduling

* chore: cleanup

* chore: cleanup

* chore: fix call flow

* chore: workaround duplicate spinner bugs

* ci: split api_2 test

* chore: increase push timeout

* ci: add method to run solo tests

* ci: configure retries compatible with worker pools

* ci: workaround concurrent polling limits

* chore: fix bug with solo tests

* chore: move import & geo tests to run solo

* chore: add artifact scripts

* chore: trigger workflow results

* ci: fix artifact path

* chore: cleanup

* chore: add timer spy

* ci: update test lists

* chore: cleanup

* ci: fix retries

* ci: move delays to createProjectDir

* ci: use same script for e2e as linux on windows

* chore: split storage-1 test

* ci: fix config

* ci: add bash env

* ci: reduce timeout on push

* ci: update test lists

* ci: update test lists

* ci: lower timeout and enable concurrent migration testing

* ci: update test list

* ci: restructure migration test setups

* ci: cleanup to use file names instead of old job names

* chore: refactor

* ci: fix dependencies

* ci: attempt to fix retry on windows

* chore: revert retry changes

* chore: undo changes to addCircleCiTags

* chore: address PR feedback

* chore: undo changes to spinners

* chore: cleanup unused files

* chore: lint & formatting

* chore: lint, remove unused import

* chore: undo changes to initialize-env.ts

* ci: windows smoke test list for non-dev branches

* chore: remove verify-api pre-push hook (#11799)

* fix: remove production env variable from amplify script execution

* fix: do not overload NODE_ENV env parameter for usage data filtering

* fix: do not overload NODE_ENV env parameter for usage data filtering

* fix: do not overload NODE_ENV env parameter for usage data filtering

* fix: test timeouts on simulator tests (#11804)

* ci: fix staleness filters (#11801)

* ci: fix staleness filters

* ci: only delete stale apps & stacks

* chore: refactor

* chore: migrate interactions category from inquirer to prompter library

* fix: default values for interactions prompter

* chore: addressed PR feedback

* chore: addressed PR feedback

* chore: Persist downstream exceptions in usage metrics (#11711)

* chore: Persist downstream exceptions in usage metrics

* fix variable name case

* chore: Populate cfn exceptions messages in AmplifyFault (#11764)

* chore: Persist cfn exceptions in usage metrics

* Add a tab between different cfn error messages

* refactor filtering the stacks with error

* build(deps): bump json5 from 1.0.1 to 1.0.2 (#11697)

Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ci: fix cleanup script throttling (#11716)

* ci: update cleanup script to reduce throttling

* chore: add extract api file

* ci: fix condition

* chore: cleanup

* chore: add back logs

* chore: move cleanup to start to avoid deleting apps while running

* chore: update cleanup script

* chore: revert build change

* chore: fix md file

* chore: cleanup

* chore: address pr feedback

* chore: comments

* chore: refactor

* chore: fix lint issues

* chore: feature flag for Lazy Loading and Custom Selection Set support (#11566)

* chore: feature flag for iOS LazyReference and ModelPath support

* update FF naming

* chore: add debug command to all e2e tests

* fix: status command with --debug flag

* feat: revamp help command (#11667)

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command

* feat: revamp help command (resolving merge conflicts)

* feat: revamp help command (remove non-null assertions)

* feat: revamp help command (remove non-null assertions)

* feat: revamp help command (revisions)

* feat: revamp help command (revisions)

* feat: revamp help command (revisions)

* feat: revamp help command (update to use array find)

* feat: revamp help command (switch to single quotes)

* feat: revamp help command (switch to single quotes)

* feat: revamp help command (put imports on same line)

* feat: revamp help command (extract api)

* feat: revamp help command (prettier on help-helpers)

* feat: revamp help command (fix tag line)

* feat: revamp help command (changing test names)

* feat: revamp help command (refactoring preserveHelpInformation)

* fix(global-prefix): remove global-prefix package (#11408)

* fix: update prepush hook to clean and rebuild before running verify extract api (#11753)

* chore: add codeql scanning (#11518)

* chore: add codeql scanning

* fix: added quality scan to codeql

* fix: make prompter multi-select indicator more distinct (#11742)

* Convert back to async method

* Add some method comments

* fix type in the comments

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: awsluja <[email protected]>
Co-authored-by: Michael Law <[email protected]>
Co-authored-by: Pavel Lazar <[email protected]>
Co-authored-by: Zachary Goldberg <[email protected]>
Co-authored-by: MorCohenAres <[email protected]>
Co-authored-by: Spencer Stolworthy <[email protected]>
Co-authored-by: Edward Foyle <[email protected]>

* chore: addressed PR feedback

* chore: script to allow simple collection of coverage from all projects (#11798)

* chore: add coverage collection script for local unit tests runs

* fix: remove unused import

* fix: updated dev dependencies

* fix: added file level doc, filtered out unwanted coverage on e2e, lib, and test files

* fix: more descriptive filename for the script

* chore: addressed PR feedback

* fix: prompt string to match e2e (#11816)

Co-authored-by: Akshay Upadhyay <[email protected]>

* chore: correctly filter failed cfn events for displaying error messages (#11815)

* chore: do not filter AWS::CloudFormation::Stack type failure events if they have valid error message

* Update packages/amplify-provider-awscloudformation/src/aws-utils/aws-cfn.js

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Pavel Lazar <[email protected]>
Co-authored-by: kuhlmanp <[email protected]>
Co-authored-by: phani-srikar <[email protected]>
Co-authored-by: Al Harris <[email protected]>
Co-authored-by: Akshay Upadhyay <[email protected]>
Co-authored-by: Edward Foyle <[email protected]>
Co-authored-by: aws-amplify-bot <[email protected]>
Co-authored-by: Pavel Lazar <[email protected]>
Co-authored-by: Danielle Adams <[email protected]>
Co-authored-by: awsluja <[email protected]>
Co-authored-by: Spencer Stolworthy <[email protected]>
Co-authored-by: Amplifiyer <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Michael Law <[email protected]>
Co-authored-by: Zachary Goldberg <[email protected]>
Co-authored-by: MorCohenAres <[email protected]>
Co-authored-by: Spencer Stolworthy <[email protected]>
Co-authored-by: akshbhu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardfoyle edwardfoyle edwardfoyle approved these changes

@sdstolworthy sdstolworthy sdstolworthy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@awsluja @sdstolworthy @edwardfoyle