Fix initialization order for _unit_step_size #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix segmentation fault that occures when
align_depth
is enabled and we subscribe to one of thecamera/aligned_depth_to_*
topics.The issue was that the
_unit_step_size
was not initialized beforegetParameters()
call, but insidegetParameters
it is used when calculating_aligned_depth_images
vectors size:realsense/realsense2_camera/src/realsense_node.cpp
Line 286 in f26dbde
So all the vectors inside
_aligned_depth_images
had size of 0 and because of that later ondata()
returnednullptr
and we had segfault when trying to call memset with a null pointerrealsense/realsense2_camera/src/realsense_node.cpp
Lines 677 to 680 in f26dbde
realsense/realsense2_camera/src/realsense_node.cpp
Lines 596 to 599 in f26dbde