-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite watcher #3123
Closed
Closed
Rewrite watcher #3123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 23, 2022
This was referenced Oct 23, 2022
Closed
Closed
This comment was marked as off-topic.
This comment was marked as off-topic.
novemberborn
force-pushed
the
rewatch
branch
from
November 14, 2022 18:54
e1c90b3
to
b45f018
Compare
novemberborn
force-pushed
the
rewatch
branch
from
November 15, 2022 19:31
b45f018
to
82dbdd5
Compare
Closing in favor of #3218. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to rewrite the watcher implementation.
Goals:
chokidar
dependency, rely onfs.watch()
.chokidar
(or similar) providesAnd as a follow-up goal, integrate with
@ava/typescript
so changes to saysrc/
are detected, and depending on whether it assumes a runningtsc
wait forbuild/
to be updated, or run immediately since it compiles prior to testing. But this is beyond AVA's current watch mode so can come later.