Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite watcher #3123

Closed
wants to merge 10 commits into from
Closed

Rewrite watcher #3123

wants to merge 10 commits into from

Conversation

novemberborn
Copy link
Member

@novemberborn novemberborn commented Oct 23, 2022

This PR aims to rewrite the watcher implementation.

Goals:

  • Remove chokidar dependency, rely on fs.watch().
  • This will require some additional logic for Linux (where we cannot watch recursively), but we don't need the full behavior that chokidar (or similar) provides
  • Simplify logic
  • Use static analysis for dependency tracking (https://github.com/vercel/nft)
  • Use self-hosted integration-style tests

And as a follow-up goal, integrate with @ava/typescript so changes to say src/ are detected, and depending on whether it assumes a running tsc wait for build/ to be updated, or run immediately since it compiles prior to testing. But this is beyond AVA's current watch mode so can come later.

@unional

This comment was marked as off-topic.

@novemberborn
Copy link
Member Author

Closing in favor of #3218.

@novemberborn novemberborn deleted the rewatch branch July 30, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants