Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report Chokidar errors #1071

Closed
novemberborn opened this issue Oct 9, 2016 · 2 comments
Closed

Report Chokidar errors #1071

novemberborn opened this issue Oct 9, 2016 · 2 comments

Comments

@novemberborn
Copy link
Member

Watch mode uses chokidar to detect changes. Chokidar can emit error events. Currently these are ignored. We should report them to the user instead as they may include clues as to why the watcher isn't detecting changes.

For example #1030 was due to Chokidar watching more files than the system allowed.

I'm thinking this should be part of the watcher's debug output, but that still takes some effort to find. Should it go in the verbose output instead?

We'll have to reproduce #1030 with this reporting enabled to see if Chokidar actually reports the errors and if it's informative enough.

@fabiospampinato
Copy link

Kind of tangential and I'm biased on this, but it might be worth exploring replacing chokidar with watcher, which could be more refined for what this library needs (native watching under windows, much better handling of EMFILE errors, rename detection...).

@novemberborn
Copy link
Member Author

This would be irrelevant if #3123 is completed.

@novemberborn novemberborn linked a pull request Oct 23, 2022 that will close this issue
5 tasks
@novemberborn novemberborn closed this as not planned Won't fix, can't repro, duplicate, stale Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants