Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source map support. Fixes: #223, #250 #254

Merged
merged 1 commit into from
Nov 23, 2015

Conversation

jamestalmage
Copy link
Contributor

Fixes #223, #250

This adds basic source map support. Since transpilation of dependencies
is not merged yet, the sourceMapCache object and lookup is a little
premature (since we will only ever have one file that we can apply
apply source maps to).

This was referenced Nov 22, 2015
@jamestalmage
Copy link
Contributor Author

Because we use require-from-string, our source maps are never written to disk. This requires the implementation of the retrieveSourceMap callback. Final solutions for #189 and #177 will need to expand on this as well.

I do not know how expensive it is to load up source-map-support in each forked process like this.

Since all errors are serialized and transmitted over IPC before logging, It may be possible to defer the stack-trace transform until it has been transmitted back to the main thread.

@jamestalmage
Copy link
Contributor Author

This needs #255 before it will pass on Windows. The Travis failure looks like a fluke.

Rebased onto master which contains referenced fix.

This adds basic source map support. Since transpilation of dependencies
is not merged yet, the `sourceMapCache` object and lookup is a little
premature (since we will only ever have one file that we can apply
apply source maps to).
sindresorhus added a commit that referenced this pull request Nov 23, 2015
@sindresorhus sindresorhus merged commit 2185921 into avajs:master Nov 23, 2015
@sindresorhus
Copy link
Member

Looks good 👍

@jamestalmage jamestalmage deleted the source-map-support branch November 23, 2015 06:40
@sindresorhus
Copy link
Member

I do not know how expensive it is to load up source-map-support in each forked process like this.

Since all errors are serialized and transmitted over IPC before logging, It may be possible to defer the stack-trace transform until it has been transmitted back to the main thread.

Let's do some benchmarking before we start investigating this. Might not make a difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants