Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PowerAssert shows incorrect line #250

Closed
Qix- opened this issue Nov 21, 2015 · 2 comments
Closed

PowerAssert shows incorrect line #250

Qix- opened this issue Nov 21, 2015 · 2 comments

Comments

@Qix-
Copy link
Contributor

Qix- commented Nov 21, 2015

I assume it's a mapping issue since we're transpiling things with babel.

screen shot 2015-11-21 at 06 28 14

screen shot 2015-11-21 at 06 28 28

As you can see the source file in question only goes to line 120, but the error message shows 299.
jamestalmage added a commit to jamestalmage/ava that referenced this issue Nov 22, 2015
@jamestalmage
Add source map support. Fixes: avajs#223, avajs#250
b41247c
jamestalmage added a commit to jamestalmage/ava that referenced this issue Nov 22, 2015
@jamestalmage
Add source map support. Fixes: avajs#223, avajs#250
1b3194c 
This adds basic source map support. Since transpilation of dependencies
is not merged yet, the `sourceMapCache` object and lookup is a little
premature (since we will only ever have one file that we can apply
apply source maps to).
@jamestalmage
Copy link
Contributor

Duplicate of #223.

PR for Fix: #254

@Qix-
Copy link
Contributor Author

Qix- commented Nov 22, 2015

👍 couldn't find it in the issue search for some reason. Thanks.

@Qix- Qix- closed this as completed Nov 22, 2015
jamestalmage added a commit to jamestalmage/ava that referenced this issue Nov 23, 2015
@jamestalmage
Add source map support. Fixes: avajs#223, avajs#250
25a3cfd 
This adds basic source map support. Since transpilation of dependencies
is not merged yet, the `sourceMapCache` object and lookup is a little
premature (since we will only ever have one file that we can apply
apply source maps to).
@jamestalmage jamestalmage mentioned this issue Nov 23, 2015
Merged
sindresorhus added a commit that referenced this issue Nov 23, 2015
@sindresorhus
Merge pull request #254 from jamestalmage/source-map-support
2185921 
Add source map support. Fixes: #223, #250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Qix- @jamestalmage