Added compatibility tracking #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dasconnor
requested review from
ceyonur,
darioush,
patrick-ogrady and
aaronbuchwald
as code owners
utils/compatibility_test.go
Outdated
Comment on lines
15
to
26
| func TestCompatibility(t *testing.T) { | ||
| subevmVersion := "v0.4.0" | ||
| expectedRPCVersion := 17 | ||
|
|
||
| compat, err := os.ReadFile("../compatibility.json") | ||
| assert.NoError(t, err) | ||
|
|
||
| var parsedCompat rpcChainCompatibility | ||
| err = json.Unmarshal(compat, &parsedCompat) | ||
| assert.NoError(t, err) | ||
| assert.Equal(t, expectedRPCVersion, parsedCompat.RPCChainVMProtocolVersion[subevmVersion]) | ||
| } |
There was a problem hiding this comment.
can we move this test to plugin/evm/version_test.go and use the actual version and actual imported rpcchainvm.ProtocolVersion from AvalancheGo, so that if we mess this up for the latest version this. test will fail?
There was a problem hiding this comment.
Added a test, for it to work tho you will need to remember to update the version in plugins/evm/version.go.
utils/compatibility_test.go
Outdated
| subevmVersion := "v0.4.0" | ||
| expectedRPCVersion := 17 | ||
|
|
||
| compat, err := os.ReadFile("../compatibility.json") |
There was a problem hiding this comment.
Can we use JSON embed here? For example: https://github.com/ava-labs/coreth/blob/master/plugin/evm/ext_data_hashes.go#L11-L13
There was a problem hiding this comment.
go:embed only works with files in a subdirectory of the test. I don't think we want to bury this json file in subdirectories, so I'm not going to make this change.
aaronbuchwald
requested changes
Nov 2, 2022
added 2 commits
November 3, 2022 12:23
plugin/evm/version_test.go
Outdated
Comment on lines
38
to
39
| _, valueInJSON := parsedCompat.RPCChainVMProtocolVersion[Version] | ||
| assert.True(t, valueInJSON) |
There was a problem hiding this comment.
We should assert that the actual value matches the rpcchainvm protocol version that we have imported from avalanchego as well.
aaronbuchwald
approved these changes
Nov 4, 2022
cmd/simulator/go.mod
Outdated
| @@ -15,7 +15,7 @@ replace github.com/ava-labs/subnet-evm => ../.. | |||
|
|
|||
| require ( | |||
| github.com/VictoriaMetrics/fastcache v1.10.0 // indirect | |||
| github.com/ava-labs/avalanchego v1.9.1 // indirect | |||
| github.com/ava-labs/avalanchego v1.9.2-rc.7 // indirect | |||
Closed
patrick-ogrady
approved these changes
Nov 4, 2022
arunraoshrap
pushed a commit
to neonmachine-shrapnel/subnet-evm
that referenced
this pull request
Nov 8, 2022
* Added compatibility tracking * Added version moved test * Cleaned up test * Bump avalanchego version and nits * go mod tidy cmd/simulator * Mark trie clean jouranl test as flaky * Bump avalanchego to v1.9.2 * Bump anr version in scripts/versions.sh * Bump anr version in go.mod * go mod tidy cmd/simulator Co-authored-by: Aaron Buchwald <[email protected]>
ceyonur
pushed a commit
that referenced
this pull request
Sep 17, 2023
* drop outbound gossip requests for non validators * nit * nit
aaronbuchwald
pushed a commit
that referenced
this pull request
Sep 19, 2023
* Drop outbound gossip requests for non-validators (#334) * drop outbound gossip requests for non validators * nit * nit * sync changes --------- Co-authored-by: Joshua Kim <[email protected]>
aaronbuchwald
pushed a commit
that referenced
this pull request
Sep 19, 2023
* Add SDK Router message handling (#316) Co-authored-by: Stephen Buttolph <[email protected]> * Fix hanging requests after Shutdown (#326) * fix requests hanging after shutdown * fix build --------- Signed-off-by: Stephen Buttolph <[email protected]> Co-authored-by: Stephen Buttolph <[email protected]> * Update to 1.10.10-rc.2 (#328) * update to avalanchego 1.10.10-rc.2 * nits * nit * Add P2P SDK Pull Gossip (#318) * add batchsize * sync changes * Drop outbound gossip for non vdrs (#862) * Drop outbound gossip requests for non-validators (#334) * drop outbound gossip requests for non validators * nit * nit * sync changes --------- Co-authored-by: Joshua Kim <[email protected]> --------- Co-authored-by: Joshua Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
compatibility.jsonsimilar to the one being added in avalanchego. Will allow external apps to determine which version of avalanchego to use without needing to parse the readme. Also added a test to make sure the json parses.This file will need to be updated with each new subnet-evm release.