fixes flakes in TestArchiveBlockChainSnapsDisabled #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
requested review from
ceyonur,
patrick-ogrady and
aaronbuchwald
as code owners
ceyonur
approved these changes
Oct 24, 2022
|
Could you add to the description how this fixes the issue and populate the tracking fields? We should be able to call |
arunraoshrap
pushed a commit
to neonmachine-shrapnel/subnet-evm
that referenced
this pull request
Nov 8, 2022
ceyonur
pushed a commit
that referenced
this pull request
Sep 14, 2023
Co-authored-by: Stephen Buttolph <[email protected]>
aaronbuchwald
pushed a commit
that referenced
this pull request
Sep 19, 2023
* Add SDK Router message handling (#316) Co-authored-by: Stephen Buttolph <[email protected]> * revert avago version bump * Fix hanging requests after Shutdown (#326) (#859) * Fix hanging requests after Shutdown (#326) * fix requests hanging after shutdown * fix build --------- Signed-off-by: Stephen Buttolph <[email protected]> Co-authored-by: Stephen Buttolph <[email protected]> * Bump avago rc (#860) * Update to 1.10.10-rc.2 (#328) * update to avalanchego 1.10.10-rc.2 * nits * nit * add batchsize * increase timeout dynamically --------- Co-authored-by: Joshua Kim <[email protected]> --------- ---------
aaronbuchwald
pushed a commit
that referenced
this pull request
Sep 19, 2023
* Add SDK Router message handling (#316) Co-authored-by: Stephen Buttolph <[email protected]> * Fix hanging requests after Shutdown (#326) * fix requests hanging after shutdown * fix build --------- Signed-off-by: Stephen Buttolph <[email protected]> Co-authored-by: Stephen Buttolph <[email protected]> * Update to 1.10.10-rc.2 (#328) * update to avalanchego 1.10.10-rc.2 * nits * nit * Add P2P SDK Pull Gossip (#318) * add batchsize * sync changes * Drop outbound gossip for non vdrs (#862) * Drop outbound gossip requests for non-validators (#334) * drop outbound gossip requests for non validators * nit * nit * sync changes --------- Co-authored-by: Joshua Kim <[email protected]> --------- Co-authored-by: Joshua Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested by
go test -count=100 -run=TestArchiveBlockChainSnapsDisabled ./corecloses: #245
If we don't synchronize on accept (leave it async) we can hit this line:
subnet-evm/core/test_blockchain.go
Line 112 in 992d683
where LastAcceptedBlock differs from LastConsensusAcceptedBlock and the state for the lastAccepted would not be available (since Accept could be processing concurrently writes may not have made it to the DB).