-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[antithesis] Add initial test setup #1166
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
commented
May 7, 2024
marun
force-pushed
the
antithesis-test-setup
branch
2 times, most recently
from
May 7, 2024 04:11
1554701
to
6ce5230
Compare
marun
changed the title
[antithesis] Propose initial test setup
[antithesis] Add initial test setup
May 7, 2024
marun
force-pushed
the
antithesis-test-setup
branch
2 times, most recently
from
May 7, 2024 04:29
1911af1
to
b4379dc
Compare
marun
force-pushed
the
antithesis-test-setup
branch
2 times, most recently
from
May 11, 2024 03:40
8dad27f
to
76dd130
Compare
marun
force-pushed
the
antithesis-test-setup
branch
2 times, most recently
from
May 13, 2024 20:15
7fb19f0
to
8823a2d
Compare
marun
force-pushed
the
antithesis-test-setup
branch
from
July 19, 2024 05:20
8823a2d
to
0ed5db9
Compare
marun
commented
Jul 19, 2024
marun
force-pushed
the
antithesis-test-setup
branch
3 times, most recently
from
July 19, 2024 08:50
3487b8c
to
b415f60
Compare
joshua-kim
reviewed
Jul 19, 2024
joshua-kim
previously approved these changes
Jul 19, 2024
darioush
previously approved these changes
Jul 23, 2024
marun
added a commit
to ava-labs/avalanchego
that referenced
this pull request
Aug 8, 2024
As per @StephenButtolph's comment: ava-labs/subnet-evm#1166 (comment) Co-authored-by: Stephen Buttolph <[email protected]>
marun
added a commit
to ava-labs/avalanchego
that referenced
this pull request
Aug 8, 2024
As per @StephenButtolph's comment: ava-labs/subnet-evm#1166 (comment) Co-authored-by: Stephen Buttolph <[email protected]>
marun
force-pushed
the
antithesis-test-setup
branch
3 times, most recently
from
August 16, 2024 10:41
9ceb33b
to
553d9a5
Compare
marun
force-pushed
the
antithesis-test-setup
branch
from
August 19, 2024 19:01
553d9a5
to
8508e32
Compare
marun
force-pushed
the
antithesis-test-setup
branch
from
August 19, 2024 22:17
8508e32
to
d319a55
Compare
darioush
approved these changes
Aug 20, 2024
This seems fine to me, also let's get @ceyonur 's approval |
ceyonur
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Do we need to add any of these as required status checks in branch settings?
Just the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR adds the scaffolding required to build images for an antithesis test setup for subnet-evm.
How this works
Adds scripts, dockerfiles and code that comprise the antithesis test setup and its tooling.
How was this tested
New CI job checking workload sanity and construction of the images.
NOTE: Due to the limitations inherent to github actions, validation of image publication and the triggering of antithesis workloads can only be performed once this PR is merged.
TODO
Pre-merge
Post-merge