Add StoppedTimer helper #3280
Merged
Add StoppedTimer helper #3280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per @StephenButtolph's comment: ava-labs/subnet-evm#1166 (comment) Co-authored-by: Stephen Buttolph <[email protected]>
marun
force-pushed
the
add-stopped-timer
branch
from
b384723
to
7ed9df8
Compare
aaronbuchwald
approved these changes
Aug 8, 2024
7 tasks
ARR4N
approved these changes
Aug 8, 2024
| @@ -11,6 +11,8 @@ import ( | |||
| "github.com/ava-labs/avalanchego/utils/logging" | |||
| "github.com/ava-labs/avalanchego/utils/set" | |||
| "github.com/ava-labs/avalanchego/utils/timer/mockable" | |||
|
|
|||
| utils_timer "github.com/ava-labs/avalanchego/utils/timer" | |||
There was a problem hiding this comment.
(optional, subjective) When a package and a local variable clash, one recommended approach is to use the pkg suffix so this would be timerpkg.
The underscore in the name is what jumped out at me as out of the ordinary.
utils/timer/stopped_timer.go
Outdated
| // This means that after calling Reset there will be no events on the | ||
| // channel until the timer fires (at which point there will be exactly | ||
| // one event sent to the channel). | ||
|
|
There was a problem hiding this comment.
(nit) You've accidentally broken the comment here. I'm not sure if doc parsers will fix that or not.
| // It enables re-using the timer across loop iterations without | ||
| // needing to have the first loop iteration perform any == nil checks | ||
| // to initialize the first invocation. | ||
| func StoppedTimer() *time.Timer { |
There was a problem hiding this comment.
I think this should also be used here:
avalanchego/network/throttling/inbound_resource_throttler.go
Lines 109 to 114 in 6626d2b
StephenButtolph
approved these changes
Aug 8, 2024
marun
added a commit
that referenced
this pull request
Aug 8, 2024
Co-authored-by: Stephen Buttolph <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per @StephenButtolph's recent comment.