Fix bloom reset #1049
Merged
Fix bloom reset #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
approved these changes
Jan 22, 2024
Merged
ceyonur
added a commit
that referenced
this pull request
Jan 22, 2024
* tweak global limit * uncomment submit * update consts * update avalanchego version * fix compilation err * simpler fix * remove mempool configs * bump latest avago rc * fix tests * update avalanchego * fix mockgen * bump ANR * remove unnecessary log levels * Fix bloom reset (#1049) * add UT for eth tx pool subscribe * fix eth tx pool subscribtion * don't use journal * simplify test * increase timeout * Update plugin/evm/tx_gossip_test.go Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]> --------- Signed-off-by: Ceyhun Onur <[email protected]> Co-authored-by: Ceyhun Onur <[email protected]> Co-authored-by: Darioush Jalali <[email protected]>
ceyonur
added a commit
that referenced
this pull request
Jan 23, 2024
* rename tx handlers * add p2p sdk handlers * fix tests * fix imports * bump min go version * downgrade golangci * remove noop handler * bump avago rc * fix uint64 * bump avalanchego rc version * fix linter * revert txpool uint change * bump subnet-evm version * run simulator in a different step * remove load test from precompile tests * run simulator in a different step * remove load test from precompile tests * rename simulator to load test * parallelize e2e steps * use checkout * split to different workflows * move to same folder * bump avago * add time to codec * fix load test (#1043) * tweak global limit * uncomment submit * update consts * update avalanchego version * fix compilation err * simpler fix * remove mempool configs * bump latest avago rc * fix tests * update avalanchego * fix mockgen * bump ANR * remove unnecessary log levels * Fix bloom reset (#1049) * add UT for eth tx pool subscribe * fix eth tx pool subscribtion * don't use journal * simplify test * increase timeout * Update plugin/evm/tx_gossip_test.go Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]> --------- Signed-off-by: Ceyhun Onur <[email protected]> Co-authored-by: Ceyhun Onur <[email protected]> Co-authored-by: Darioush Jalali <[email protected]> * Fix racey bloom access and replace time.Sleep with require.Eventually --------- Signed-off-by: Ceyhun Onur <[email protected]> Co-authored-by: Patrick O'Grady <[email protected]> Co-authored-by: Darioush Jalali <[email protected]> Co-authored-by: Stephen Buttolph <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
There is a bug that prevents pending txs to be added to bloom filter after reset.
How this works
Change variables from pendingTxs to iterated txs
How this was tested
Added UT
How is this documented
No need