fix load test #1043
Merged
fix load test #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-ogrady
commented
Jan 5, 2024
Closed
ceyonur
requested review from
ceyonur,
darioush and
aaronbuchwald
as code owners
|
Looks like this needs to bump the |
Comment on lines
75
to
76
| "log-level": "debug", | ||
| "log-display-level": "debug" |
There was a problem hiding this comment.
Suggested change
| "log-level": "debug", | |
| "log-display-level": "debug" | |
| "log-level": "debug", |
There is no log-display-level for the C-Chain specific config
| @@ -66,12 +66,14 @@ func NewDefaultANRConfig() ANRConfig { | |||
| AvalancheGoExecPath: os.ExpandEnv("$GOPATH/src/github.com/ava-labs/avalanchego/build/avalanchego"), | |||
| PluginDir: os.ExpandEnv("$GOPATH/src/github.com/ava-labs/avalanchego/build/plugins"), | |||
| GlobalNodeConfig: `{ | |||
| "log-level":"info", | |||
There was a problem hiding this comment.
Should we remove log-display-level if we are going to specify log-level? Also, not sure why we were originally specifying log-display-level here (although it looks like I wrote it, I think I copied it from somewhere).
Most likely this was to log to stdout without writing to the log directory. I'd assume if anything we'd want more specific logs written to stdout, so that we can inspect them on test failure without crowding out the output from the network runner, which pipes the logs from stdout (as I understand it).
darioush
approved these changes
Jan 22, 2024
* add UT for eth tx pool subscribe * fix eth tx pool subscribtion * don't use journal * simplify test * increase timeout
Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]>
ceyonur
added a commit
that referenced
this pull request
Jan 23, 2024
* rename tx handlers * add p2p sdk handlers * fix tests * fix imports * bump min go version * downgrade golangci * remove noop handler * bump avago rc * fix uint64 * bump avalanchego rc version * fix linter * revert txpool uint change * bump subnet-evm version * run simulator in a different step * remove load test from precompile tests * run simulator in a different step * remove load test from precompile tests * rename simulator to load test * parallelize e2e steps * use checkout * split to different workflows * move to same folder * bump avago * add time to codec * fix load test (#1043) * tweak global limit * uncomment submit * update consts * update avalanchego version * fix compilation err * simpler fix * remove mempool configs * bump latest avago rc * fix tests * update avalanchego * fix mockgen * bump ANR * remove unnecessary log levels * Fix bloom reset (#1049) * add UT for eth tx pool subscribe * fix eth tx pool subscribtion * don't use journal * simplify test * increase timeout * Update plugin/evm/tx_gossip_test.go Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]> --------- Signed-off-by: Ceyhun Onur <[email protected]> Co-authored-by: Ceyhun Onur <[email protected]> Co-authored-by: Darioush Jalali <[email protected]> * Fix racey bloom access and replace time.Sleep with require.Eventually --------- Signed-off-by: Ceyhun Onur <[email protected]> Co-authored-by: Patrick O'Grady <[email protected]> Co-authored-by: Darioush Jalali <[email protected]> Co-authored-by: Stephen Buttolph <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: add
NoLocals: false+ IncreaseGlobalSlotsconfig for the load test to ensure nothing gets dropped (still racy even with faster bloom)Why this should be merged
How this works
How this was tested
How is this documented