Add etna-time configs
#463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iansuvak
requested review from
feuGeneA,
geoff-vball,
minghinmatthewlam,
bernard-avalabs,
michaelkaplan13 and
cam-schultz
iansuvak
commented
Aug 28, 2024
| @@ -67,6 +68,9 @@ type Config struct { | |||
| DeciderURL string `mapstructure:"decider-url" json:"decider-url"` | |||
| SignatureCacheSize uint64 `mapstructure:"signature-cache-size" json:"signature-cache-size"` | |||
|
|
|||
| // mapstructure doesn't handle time.Time out of the box so handle it manually | |||
| EtnaTime time.Time `json:"etna-time"` | |||
There was a problem hiding this comment.
I would have liked to do omitempty so that tests don't write the field out when marshaling JSON here but zero time value still gets written out unless the field type is *time.Time which seemed messier.
The value that does get written out is correctly parsed by viper to be zero time value. As a result tests run the pre-Etna case unless otherwise specified.
Merged
geoff-vball
approved these changes
Aug 29, 2024
| } | ||
| } | ||
|
|
||
| func (s *SignatureAggregator) unmarshalResponse(responseBytes []byte) (blsSignatureBuf, error) { |
There was a problem hiding this comment.
Can we leave TODOs and create a ticket for when this logic is okay to clean up?
There was a problem hiding this comment.
Added TODO and entered: #466
Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.20.1 to 2.20.2. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.20.1...v2.20.2) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…ersions.sh" This reverts commit 47cfef6.
…m/onsi/ginkgo/v2-2.20.2 Bump github.com/onsi/ginkgo/v2 from 2.20.1 to 2.20.2
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.65.0 to 1.66.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.65.0...v1.66.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.34.1 to 1.34.2. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.34.1...v1.34.2) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…m/onsi/gomega-1.34.2 Bump github.com/onsi/gomega from 1.34.1 to 1.34.2
…lang.org/grpc-1.66.0 Bump google.golang.org/grpc from 1.65.0 to 1.66.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This will allow for merging of ACP-118 changes and toggling them based on the configured timestamp of the Etna upgrade
How this works
GetTime()method directly instead of relying onmapstructuretags sincetime.Timeisn't directly handled by it.How this was tested
etna-timeconfiguration set in the past, unset and set in the future. As expected, only future and unset cases returned a valid signature.How is this documented