Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ACP-118 interface #383

Closed
iansuvak opened this issue Jul 23, 2024 · 2 comments · Fixed by #408
Closed

Use ACP-118 interface #383

iansuvak opened this issue Jul 23, 2024 · 2 comments · Fixed by #408
Labels
enhancement New feature or request Warp Signature API API service for serving arbitrary Warp signatures from any VM
Milestone
Signature Aggrega...

Comments

@iansuvak
Copy link
Contributor

Context and scope
Once ACP-118 has been implemented we need to switch our AppRequests to use the new format as well as expose the justification field in the raw-message interface

Discussion and alternatives

Open questions
@iansuvak iansuvak added the enhancement New feature or request label Jul 23, 2024
@meaghanfitzgerald meaghanfitzgerald added the Warp Signature API API service for serving arbitrary Warp signatures from any VM label Jul 26, 2024
@michaelkaplan13
Copy link
Collaborator

This should now be unblocked with the Subnet EVM implementation of the ACP-118 handlers added in this PR: https://github.com/ava-labs/subnet-evm/pull/1260/files

@iansuvak
Copy link
Contributor Author

iansuvak commented Aug 2, 2024

We still need Coreth to implement it as well. But the interface won't change and tests for subnet to subnet messaging should pass

@iansuvak iansuvak mentioned this issue Aug 19, 2024
Closed
@feuGeneA feuGeneA mentioned this issue Aug 22, 2024
Merged
@iansuvak iansuvak mentioned this issue Aug 28, 2024
Merged
@github-project-automation github-project-automation bot moved this from Backlog 🗄️ to Done ✅ in Platform Engineering Group Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Warp Signature API API service for serving arbitrary Warp signatures from any VM
Projects
Platform Engineering Group
Archived in project
Milestone
Signature Aggregator API - MVP
Development

Successfully merging a pull request may close this issue.

integrate ACP-118 ava-labs/icm-services
3 participants
@iansuvak @michaelkaplan13 @meaghanfitzgerald