Rename subnet -> blockchain in Config #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cam-schultz
requested review from
michaelkaplan13,
minghinmatthewlam,
gwen917,
geoff-vball and
bernard-avalabs
as code owners
|
Thanks for doing this! Just want to link the ticket we had for this issue here #170 |
michaelkaplan13
approved these changes
Mar 4, 2024
geoff-vball
approved these changes
Mar 4, 2024
minghinmatthewlam
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Fixes #170
The application requires unique Blockchain IDs in the configuration, but the naming suggests that Subnets also need to be unique. Subnets can contain multiple blockchains, in which case there would need to be multiple entries in
SourceSubnetsandDestinationSubnetswith the same subnet ID.How this works
Renames
SourceSubnettoSourceBlockchainandDestinationSubnettoDestinationBlockchainin the configuration.How this was tested
CI
How is this documented
Updated README