Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key the configuration by blockchain, not subnet #170

Closed
cam-schultz opened this issue Feb 2, 2024 · 1 comment
Closed

Key the configuration by blockchain, not subnet #170

cam-schultz opened this issue Feb 2, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@cam-schultz
Copy link
Collaborator

Context and scope
The two primary types that compose Config are DestinationSubnet and SourceSubnet, each of which must specify a unique blockchain ID, but the subnet ID may be non-unique within each list. This is because subnets can support multiple blockchains, but a blockchain can only ever belong to a single subnet.

To reflect this, we should change these types to DestinationBlockchain and SourceBlockchain to better reflect what each entry represents.
@cam-schultz cam-schultz added the enhancement New feature or request label Feb 2, 2024
@cam-schultz cam-schultz mentioned this issue Feb 2, 2024
Merged
@geoff-vball geoff-vball mentioned this issue Mar 4, 2024
Merged
@cam-schultz
Copy link
Collaborator Author

Fixed by #212

@github-project-automation github-project-automation bot moved this from Backlog 🗄️ to Done ✅ in Platform Engineering Group Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Platform Engineering Group
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cam-schultz