Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tmpnet] Avoid calling Stat in advance of Read/Open #3356

Merged
merged 2 commits into from
Sep 4, 2024
Merged

[tmpnet] Avoid calling Stat in advance of Read/Open #3356

merged 2 commits into from
Sep 4, 2024

Commits on Sep 3, 2024

  1. [tmpnet] Avoid calling Stat in advance of Read/Open 

    Checking for a file/dir in advance of attempting to open it is
redundant and invites race conditions:

https://github.com/ava-labs/avalanchego/actions/runs/10688505984/job/29628507363

Prefer checking for ErrNotExist in the call to read the file/dir.
    @marun
    marun committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    bfb1e07 View commit details
    Browse the repository at this point in the history

  2. fixup: respond to review feedback

    @marun
    marun committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    ddd2960 View commit details
    Browse the repository at this point in the history