[tmpnet] Avoid calling Stat in advance of Read/Open #3356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking for a file/dir in advance of attempting to open it is redundant and invites race conditions: https://github.com/ava-labs/avalanchego/actions/runs/10688505984/job/29628507363 Prefer checking for ErrNotExist in the call to read the file/dir.
StephenButtolph
approved these changes
Sep 4, 2024
darioush
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Checking for a file/dir in advance of attempting to open it is redundant and invites race conditions where error handling is not duplicated:
https://github.com/ava-labs/avalanchego/actions/runs/10688505984/job/29628507363
How this works
Removes calls to Stat in tmpnet code and ensures error handling for ErrNotExist in the calls to read a file or dir.
How this was tested
CI