Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[antithesis] Refactor image build for reuse by other repos #3198

Merged
merged 4 commits into from
Aug 2, 2024
Merged

[antithesis] Refactor image build for reuse by other repos #3198

merged 4 commits into from
Aug 2, 2024

Conversation

marun
Copy link
Contributor

@marun marun commented Jul 17, 2024 •
edited
Loading

Why this should be merged

Refactors image build scripting to enable reuse by other repos.

How this works

  • move reusable functionality to functions
  • move functions to a library script
  • ensure all arguments to the functions are accepted as parameters to avoid depending on env vars
  • update builder image dockerfiles to be repo-agnostic
  • refactor test script for reuse

How this was tested

CI

@marun marun added testing This primarily focuses on testing ci This focuses on changes to the CI process labels Jul 17, 2024
@marun marun self-assigned this Jul 17, 2024
@marun marun force-pushed the antithesis-image-build-reuse branch from d51003d to fe3cfc3 Compare July 17, 2024 06:10
@marun marun force-pushed the antithesis-image-build-reuse branch from fe3cfc3 to 41c5ff4 Compare July 19, 2024 05:17
@marun
Copy link
Contributor Author

marun commented Jul 19, 2024

Added new commit updating the test script for reuse.

@marun marun force-pushed the antithesis-image-build-reuse branch 3 times, most recently from 54267d9 to 6ec8897 Compare July 19, 2024 05:23
@marun marun mentioned this pull request Jul 19, 2024
Merged
7 tasks
@marun marun force-pushed the antithesis-image-build-reuse branch from f3c96be to 0b4245c Compare August 2, 2024 18:23
@StephenButtolph StephenButtolph added this to the v1.11.11 milestone Aug 2, 2024
@StephenButtolph StephenButtolph added this pull request to the merge queue Aug 2, 2024
Merged via the queue into master with commit 1e904fb Aug 2, 2024
20 checks passed
@StephenButtolph StephenButtolph deleted the antithesis-image-build-reuse branch August 2, 2024 21:22
@marun marun mentioned this pull request Aug 2, 2024
Merged
marun added a commit that referenced this pull request Aug 8, 2024
@marun
[antithesis] Refactor image build for reuse by other repos (#3198)
01ef12c
marun added a commit that referenced this pull request Aug 8, 2024
@marun
[antithesis] Refactor image build for reuse by other repos (#3198)
eacccf1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsachiherman tsachiherman tsachiherman approved these changes

@StephenButtolph StephenButtolph StephenButtolph approved these changes

@abi87 abi87 Awaiting requested review from abi87

Assignees

@marun marun

Labels
ci This focuses on changes to the CI process testing This primarily focuses on testing
Projects
Platform Engineering Group
Archived in project
Milestone
v1.11.11
Development

Successfully merging this pull request may close these issues.
3 participants
@marun @StephenButtolph @tsachiherman