Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vms/platformvm: Add processStandardTxs helper #2461

Merged
merged 9 commits into from
Dec 11, 2023
Merged

vms/platformvm: Add processStandardTxs helper #2461

merged 9 commits into from
Dec 11, 2023

Conversation

dhrubabasu
Copy link
Contributor

Why this should be merged

Adds a processStandardTxs helper which will also be used in ProposalBlocks

Factored out of #2451

How this works

pretty straightforward

How this was tested

CI

@dhrubabasu dhrubabasu added the cleanup Code quality improvement label Dec 10, 2023
@dhrubabasu dhrubabasu added this to the v1.10.18 milestone Dec 10, 2023
@dhrubabasu dhrubabasu self-assigned this Dec 10, 2023
abi87
abi87 reviewed Dec 11, 2023
View reviewed changes
Copy link
Contributor

@abi87 abi87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd defer merging this after having evaluated the alternative design in #2439 and #2442, which should be slightly more memory efficient albeit slightly more complex to review

@StephenButtolph StephenButtolph added this pull request to the merge queue Dec 11, 2023
Merged via the queue into dev with commit 2fd8931 Dec 11, 2023
16 checks passed
@StephenButtolph StephenButtolph deleted the process-standard-txs-helper branch December 11, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrick-ogrady patrick-ogrady patrick-ogrady left review comments

@StephenButtolph StephenButtolph StephenButtolph approved these changes

@abi87 abi87 abi87 approved these changes

@danlaine danlaine Awaiting requested review from danlaine

Assignees

@dhrubabasu dhrubabasu

Labels
cleanup Code quality improvement
Projects
Platform Engineering Group
Archived in project
Milestone
v1.10.18
Development

Successfully merging this pull request may close these issues.
4 participants
@dhrubabasu @patrick-ogrady @abi87 @StephenButtolph