Allow decision txs in proposal blocks #2442
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abi87
changed the title
abi87
commented
Dec 7, 2023
| @@ -29,7 +29,7 @@ import ( | |||
| "github.com/ava-labs/avalanchego/vms/platformvm/txs/mempool" | |||
| ) | |||
|
|
|||
| func TestVerifierVisitProposalBlock(t *testing.T) { | |||
| func TestApricotVerifierVisitProposalBlock(t *testing.T) { | |||
There was a problem hiding this comment.
As usual this tests are not well maintained.
Introducing the following convention:
The first word after test is the fork that the test targets. We use LatestFork it the test is meant to be carried out across forks, so to remember to update the test.
This was referenced Dec 9, 2023
abi87
commented
Dec 11, 2023
| onAcceptState: onProposalBlockState, | ||
| statelessBlock: b, | ||
| timestamp: onProposalBlockState.GetTimestamp(), | ||
| } | ||
| if err := v.processStandardTxs(b.Transactions, proposalBlkState); err != nil { |
There was a problem hiding this comment.
the import/export UTXOs are not correctly handled upon accept here
|
Superseded by #2451 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Allow inclusion of standard txs in proposal block once Durango is activated
How this works
How this was tested
CI + mainnet sync