Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export snowman bootstrapper #2331

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

Factored out of #2297 to keep testing reasonable with the removal of ForceAccepted from the bootstrapping interface.

How this works

Returns a struct rather than an interface from the New function.

How this was tested

CI

@StephenButtolph StephenButtolph added consensus This involves consensus cleanup Code quality improvement labels Nov 17, 2023
@StephenButtolph StephenButtolph added this to the v1.10.16 milestone Nov 17, 2023
@StephenButtolph StephenButtolph self-assigned this Nov 17, 2023
@StephenButtolph StephenButtolph added this pull request to the merge queue Nov 17, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 17, 2023
@StephenButtolph StephenButtolph added this pull request to the merge queue Nov 17, 2023
Merged via the queue into dev with commit dbc209c Nov 17, 2023
16 checks passed
@StephenButtolph StephenButtolph deleted the export-snowman-bootstrapper branch November 17, 2023 20:12
joshua-kim added a commit that referenced this pull request Nov 20, 2023
commit 40934bb
Author: Dan Laine <[email protected]>
Date:   Fri Nov 17 15:26:22 2023 -0500

    `platformvm.VM` -- replace `Config` field with `validators.Manager` (#2319)

commit a803f38
Author: Stephen Buttolph <[email protected]>
Date:   Fri Nov 17 15:14:36 2023 -0500

    Remove common.Config from syncer.Config (#2330)

commit dbc209c
Author: Stephen Buttolph <[email protected]>
Date:   Fri Nov 17 14:48:54 2023 -0500

    Export snowman bootstrapper (#2331)

Signed-off-by: Joshua Kim <[email protected]>
joshua-kim added a commit that referenced this pull request Nov 20, 2023
commit 40934bb
Author: Dan Laine <[email protected]>
Date:   Fri Nov 17 15:26:22 2023 -0500

    `platformvm.VM` -- replace `Config` field with `validators.Manager` (#2319)

commit a803f38
Author: Stephen Buttolph <[email protected]>
Date:   Fri Nov 17 15:14:36 2023 -0500

    Remove common.Config from syncer.Config (#2330)

commit dbc209c
Author: Stephen Buttolph <[email protected]>
Date:   Fri Nov 17 14:48:54 2023 -0500

    Export snowman bootstrapper (#2331)

Signed-off-by: Joshua Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality improvement consensus This involves consensus
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants