Remove common.Config from syncer.Config #2330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
added
consensus
StephenButtolph
changed the base branch from
dev
to
remove-bootstrapping-retry-config
abi87
reviewed
Nov 17, 2023
abi87
approved these changes
Nov 17, 2023
dhrubabasu
approved these changes
Nov 17, 2023
joshua-kim
added a commit
that referenced
this pull request
Nov 20, 2023
commit 40934bb Author: Dan Laine <[email protected]> Date: Fri Nov 17 15:26:22 2023 -0500 `platformvm.VM` -- replace `Config` field with `validators.Manager` (#2319) commit a803f38 Author: Stephen Buttolph <[email protected]> Date: Fri Nov 17 15:14:36 2023 -0500 Remove common.Config from syncer.Config (#2330) commit dbc209c Author: Stephen Buttolph <[email protected]> Date: Fri Nov 17 14:48:54 2023 -0500 Export snowman bootstrapper (#2331) Signed-off-by: Joshua Kim <[email protected]>
joshua-kim
added a commit
that referenced
this pull request
Nov 20, 2023
commit 40934bb Author: Dan Laine <[email protected]> Date: Fri Nov 17 15:26:22 2023 -0500 `platformvm.VM` -- replace `Config` field with `validators.Manager` (#2319) commit a803f38 Author: Stephen Buttolph <[email protected]> Date: Fri Nov 17 15:14:36 2023 -0500 Remove common.Config from syncer.Config (#2330) commit dbc209c Author: Stephen Buttolph <[email protected]> Date: Fri Nov 17 14:48:54 2023 -0500 Export snowman bootstrapper (#2331) Signed-off-by: Joshua Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
common.Configfunctions #2328Why this should be merged
Working to remove the
common.Configandcommon.Bootstrapper, this is the last place that uses thecommon.Configother than thecommon.Bootstrapper.How this works
Directly uses the required fields from the
common.Configin thesyncer.Config.How this was tested
CI