Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_radar_fusion_to_detected_object): fix variableScope #8429

Merged

Conversation

Nagi70
Copy link
Contributor

@Nagi70 Nagi70 commented Aug 9, 2024

Description

This is a fix based on cppcheck variableScope warnings

perception/autoware_radar_fusion_to_detected_object/src/radar_fusion_to_detected_object.cpp:274:10: style: The scope of the variable 'sum_target_value' can be reduced. [variableScope]
  double sum_target_value = 0.0;
         ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Nagi70 <[email protected]>
@Nagi70 Nagi70 requested a review from veqcc August 9, 2024 08:17
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Aug 9, 2024
Copy link

github-actions bot commented Aug 9, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miursh miursh added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 11, 2024
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Aug 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.69%. Comparing base (2c4e953) to head (c4695eb).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8429      +/-   ##
==========================================
- Coverage   23.89%   23.69%   -0.20%     
==========================================
  Files        1380     1378       -2     
  Lines      101584   101368     -216     
  Branches    38637    38495     -142     
==========================================
- Hits        24269    24018     -251     
- Misses      74857    74952      +95     
+ Partials     2458     2398      -60     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 23.73% <ø> (-0.16%) ⬇️ Carriedforward from e8a0035

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miursh
Copy link
Contributor

miursh commented Aug 13, 2024

@Nagi70
Could you try merging the main branch of AutowareFoundation into your branch in order to pass the CI tests?

@kobayu858
Copy link
Contributor

@miursh
Thanks for the advice, I have merged the main branch.

@miursh miursh merged commit bbc8525 into autowarefoundation:main Aug 13, 2024
28 of 30 checks passed
xtk8532704 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 15, 2024
…owarefoundation#8429)

fix:variableScope

Signed-off-by: Nagi70 <[email protected]>
Co-authored-by: kobayu858 <[email protected]>
Signed-off-by: xtk8532704 <[email protected]>
mbharatheesha pushed a commit to nobleo/autoware.universe that referenced this pull request Aug 16, 2024
…owarefoundation#8429)

fix:variableScope

Signed-off-by: Nagi70 <[email protected]>
Co-authored-by: kobayu858 <[email protected]>
Signed-off-by: Mukunda Bharatheesha <[email protected]>
mbharatheesha pushed a commit to nobleo/autoware.universe that referenced this pull request Aug 16, 2024
@kobayu858 kobayu858 deleted the fix/cppcheck_variableScope_per-1 branch August 21, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants