Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make object retrieval RPC logging match HTTP logging #3299

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Dec 9, 2024

This PR makes error logging consistent between RPC and HTTP object retrieval (after PR #3293).

Code contributor checklist:

@teor2345 teor2345 added the improvement it is already working, but can be better label Dec 9, 2024
@teor2345 teor2345 self-assigned this Dec 9, 2024
@nazar-pc
Copy link
Member

nazar-pc commented Dec 9, 2024

Looks like an import is missing

@teor2345
Copy link
Contributor Author

teor2345 commented Dec 9, 2024

Looks like an import is missing

Yeah I just fixed that, sorry! I was rushing and focused on the underlying issue.

@teor2345 teor2345 enabled auto-merge December 9, 2024 22:31
@teor2345 teor2345 added this pull request to the merge queue Dec 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 9, 2024
@teor2345 teor2345 added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 3b8d181 Dec 10, 2024
8 checks passed
@teor2345 teor2345 deleted the obj-rpc-log branch December 10, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement it is already working, but can be better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants