Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify gateway HTTP server code using typed parameters #3293

Merged
merged 5 commits into from
Dec 10, 2024

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Dec 9, 2024

This PR uses Blake3Hash rather than String to simplify some of the gateway HTTP server code.

Code contributor checklist:

@teor2345 teor2345 added refactor networking Subspace networking (DSN) labels Dec 9, 2024
@teor2345 teor2345 self-assigned this Dec 9, 2024
nazar-pc
nazar-pc previously approved these changes Dec 9, 2024
Copy link
Member

@shamil-gadelshin shamil-gadelshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works well.

Base automatically changed from gateway-http-server to main December 9, 2024 11:41
@shamil-gadelshin shamil-gadelshin dismissed stale reviews from nazar-pc and themself December 9, 2024 11:41

The base branch was changed.

@teor2345 teor2345 enabled auto-merge December 9, 2024 22:08
@teor2345 teor2345 added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 6a6cfb6 Dec 10, 2024
8 checks passed
@teor2345 teor2345 deleted the gateway-http-server-types branch December 10, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
networking Subspace networking (DSN) refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants