Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prometheus exporter package (fixes issues with build info gauge when using OTEL) #92

Merged
merged 6 commits into from
Nov 2, 2023

Conversation

brettimus
Copy link
Collaborator

@brettimus brettimus commented Sep 26, 2023

Finally, our build info metric should work as expected with the open-telemetry prometheus exporter!

There is some funkiness with the versioning (also mentioned in a comment below).

It looks like we downgraded the opentelemetry-exporter-prometheus pacakge from a 1.x to a 0.41... however! This is because the packaged changed how they were doing versioning about a year ago.

So, the "latest" on pypi is a 1.12 release candidate (what we've been using up until now), but that's not actually the latest release. All of the latest releases are 0.x....... it's confusing.

So, the 0.41b0 release from 4 September, 2023 is actually the latest

image

@brettimus
Copy link
Collaborator Author

brettimus commented Sep 26, 2023

ah this might be useless -- these packages were updated in #89

okay nevermind — the most recent releases of the prometheus exporter are being released under 0.x minor-beta branches, even though a year ago there was a major release (a 1.12 release candidate)

so, we need to fix the version to 0.41b0 to get the fix to prometheus gauges

see: https://pypi.org/project/opentelemetry-exporter-prometheus/0.41b0/#history

@brettimus brettimus changed the title [WIP] Update opentelemetry packages [WIP] Update prometheus exporter package (fixes issues with build info gauge when using OTEL) Sep 26, 2023
@brettimus brettimus changed the title [WIP] Update prometheus exporter package (fixes issues with build info gauge when using OTEL) Update prometheus exporter package (fixes issues with build info gauge when using OTEL) Nov 1, 2023
@brettimus
Copy link
Collaborator Author

alright there was an API change in the updated PrometheusMetricReader that breaks things 😭

@brettimus
Copy link
Collaborator Author

okay fix was easy — the old prometheus exporter from otel had a "prefix" option, which is no longer supported. we didn't seem to be using it anyhow.

@brettimus brettimus merged commit 0535e75 into main Nov 2, 2023
3 checks passed
@brettimus brettimus deleted the update-opentelemetry-sdk branch March 15, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants