Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_info metric does not work with OpenTelemetry tracker #38

Closed
brettimus opened this issue May 11, 2023 · 5 comments
Closed

build_info metric does not work with OpenTelemetry tracker #38

brettimus opened this issue May 11, 2023 · 5 comments

Comments

@brettimus
Copy link
Collaborator

We will need to wait for an upstream fix to the opentelemetry-python project's prometheus metric reader.

There is an open PR to fix this in the opentelemetry-python repo: open-telemetry/opentelemetry-python#3306

@emschwartz
Copy link

If the main issue is that it reports it as a counter instead of a gauge, couldn't we just let it be a counter in the meantime? I think all the queries will still work correctly as long as the value of the counter remains at 1

@brettimus
Copy link
Collaborator Author

that's a fair point. what seems to happen though is no build_info metric is defined. only build_info_total

image image

@emschwartz
Copy link

Ah, oh course. That's annoying

@brettimus
Copy link
Collaborator Author

opentelemetry-python v1.20 includes the fix for this! i will open a PR that mentions this in the README (that versions before that do not work with build info)

@brettimus
Copy link
Collaborator Author

closed with #92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants