-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to set Latest Completed ToDos for all cars in new user setup #261
Conversation
What is the goal of this? -- nevermind I think the wizard few screens will eventually become more complicated than that. Maybe it's easier to configure the cars one by one. |
When my parents were first setting up their accounts, they added two cars in the first of the new user setup screens. The next setup screen asks for the last time that you changed the car's oil and tires, but it didn't specify which of the two cars that it was for, and only offered 1 car's worth of input fields. This allows the user to set the latest oil change and tire change mileages for all of the car's that they added in the first new user setup screen. I removed you from the review for now because I realized that I forgot to check if the tests were working. Turns out, unsurprisingly, they aren't working. I'm going to grab dinner now but I'll get the tests passing later this evening and add you back to the review. |
Codecov Report
@@ Coverage Diff @@
## develop #261 +/- ##
===========================================
+ Coverage 88.58% 88.65% +0.07%
===========================================
Files 130 130
Lines 5044 5085 +41
===========================================
+ Hits 4468 4508 +40
- Misses 576 577 +1
Continue to review full report at Codecov.
|
Added you back to review the changes, unit tests are back to working now. I agree that the onboarding will likely get more complicated in the future, and that it will make sense to set up cars one by one. That will be a pretty big reworking and would tie well into our idea of capping free tier users at one car, so maybe that could be a task for sometime soon? I can start putting together some Figma sketches or something to brainstorm the screenflow for that when the time comes. |
With the next PR, we'll have to add units validation first: you don't want to manually convert your mileage to kilometers if you're in the US ;) |
class _TodoFieldsState extends State<_TodoFields> { | ||
_TodoFieldsState(this.c, this.formKey, this.showName); | ||
|
||
final Car c; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you don't need to repeat the variables from the StatefulWidget. You can get the values using widget.c
Closes #194.