Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flesh out client tests #252

Merged
merged 13 commits into from
Oct 23, 2024
Merged

Flesh out client tests #252

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e5623c6
Add uuid as dep
tstirrat15 Oct 21, 2024
684b192
Add handle to connection in client struct
tstirrat15 Oct 22, 2024
9d6813f
Flesh out client tests
tstirrat15 Oct 22, 2024
e494456
Rename client, fix use of page buffer, use random string generator
tstirrat15 Oct 22, 2024
92be241
Revert deps changes
tstirrat15 Oct 22, 2024
6253c05
Fix lint issues
tstirrat15 Oct 22, 2024
dfcffdd
Remove build step that doesn't do anything different from test
tstirrat15 Oct 22, 2024
b6f2171
Use helper, simplify loops
tstirrat15 Oct 23, 2024
c445712
Fix flakes by adding consistency
tstirrat15 Oct 23, 2024
be80b84
Use WithCancel for good form
tstirrat15 Oct 23, 2024
b1edb93
Move client connection closing into helper
tstirrat15 Oct 23, 2024
27500c0
Make client private
tstirrat15 Oct 23, 2024
8af9101
Add merge queue to set of triggers
tstirrat15 Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions .github/workflows/build.yaml
View file
Open in desktop

This file was deleted.

9 changes: 9 additions & 0 deletions v1/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,18 @@ import (
//
// Clients are backed by a gRPC client and as such are thread-safe.
type Client struct {
// Provide a handle on the underlying connection to enable cleanup
// behaviors (among others)
conn *grpc.ClientConn
v1.SchemaServiceClient
v1.PermissionsServiceClient
v1.WatchServiceClient
}

func (c *Client) Close() error {
return c.conn.Close()
}

// ClientWithExperimental represents and open connection to Authzed with
// experimental services available.
//
Expand All @@ -34,6 +41,7 @@ func NewClient(endpoint string, opts ...grpc.DialOption) (*Client, error) {
}

return &Client{
conn,
v1.NewSchemaServiceClient(conn),
v1.NewPermissionsServiceClient(conn),
v1.NewWatchServiceClient(conn),
Expand All @@ -50,6 +58,7 @@ func NewClientWithExperimentalAPIs(endpoint string, opts ...grpc.DialOption) (*C

return &ClientWithExperimental{
Client{
conn,
v1.NewSchemaServiceClient(conn),
v1.NewPermissionsServiceClient(conn),
v1.NewWatchServiceClient(conn),
Expand Down
Loading
Loading