Flesh out client tests #252
Conversation
| require.NoError(err) | ||
| } | ||
|
|
||
| func TestCheck(t *testing.T) { |
There was a problem hiding this comment.
I'm wondering if these should be Examples and not Tests?
There was a problem hiding this comment.
They're tests in the other repositories, and I want them to be exercised by the test harness to demonstrate that they currently work with the library.
There was a problem hiding this comment.
Examples get run with go test they just also show up in the docs as examples
|
@ecordell i'm also a little worried that I have a flake in the |
v1/client_test.go
Outdated
| require.NoError(err) | ||
|
|
||
| // Validate export | ||
| exportResponse, err := client.PermissionsServiceClient.ExportBulkRelationships(context.Background(), &v1.ExportBulkRelationshipsRequest{}) |
There was a problem hiding this comment.
since these are meant as examples, maybe it would be good to make a context with cancellation and pass it in?
ctx, cancel := context.WithCancel(context.Background())
t.Cleanup(cancel)
ctx = context.WithTimeout(ctx, 5*time.Second)etc
v1/client.go
Outdated
| @@ -11,6 +11,9 @@ import ( | |||
| // | |||
| // Clients are backed by a gRPC client and as such are thread-safe. | |||
| type Client struct { | |||
| // Provide a handle on the underlying connection to enable cleanup | |||
| // behaviors (among others) | |||
| Conn *grpc.ClientConn | |||
There was a problem hiding this comment.
let's make this conn (private) and then add a top level func (Client) Close() error method?
Description
We had a user asking in Discord about how to consume a server stream, and I was going to point them at the tests when I realized that we don't actually have those tests in this repo. This is more about having a mechanism for documentation than about any concern about correctness.
Changes
uuidas an explicit dep for generating test tokensConnas a member of the client struct so that callers can do things like teardown logicTesting
Review, see that things are green