-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow symfony-7 in composer.json #188
Conversation
Hey @mkilmanas thanks a lot for contributing this; our team is at an offsite this week so my bandwidth is a little limited, but I'll take a look at this as soon as I'm back at my desk next week. Appreciate it! |
@evansims any chance to review this anytime soon? |
Hey @evansims , is there anything happening at all? It's been over a month and no update. |
Will be needing this soon if our company was to implement Auth0 |
@evansims do you think this PR could be merged shortly ? This could be a showstopper in the adaption of auth0 for some projects if this SDK is not compatible with sf7 |
We have run out of patience and made a fork of this bundle -> https://packagist.org/packages/elvi/auth0-symfony We will aim to maintain compatibility/updates as soon as they come to this official bundle, but also we will try to merge fixes/updates more proactively. No promises/guarantees though - still it's an open-source thing. @gusdeboer @ip512 - feel free to give it a try (and any feedback welcome) |
This release includes experimental community-contributed support for Symfony 7. If you encounter any issues, please [open an issue on GitHub](https://github.com/auth0/symfony/issues). **Added** - Support for Symfony 7. [\#188](#188) ([mkilmanas](https://github.com/mkilmanas)) - Support string concatenation of scopes. [\#183](#183) ([mkilmanas](https://github.com/mkilmanas)) **Changed** - Dashes in JWT permissions/scopes are now normalized. [\#184](#184) ([mkilmanas](https://github.com/mkilmanas)) **Fixed** - Fixed an issue in controller constructors using a `$container` argument. [\#190)](#190) ([mkilmanas](https://github.com/mkilmanas))
This release includes experimental community-contributed support for Symfony 7. If you encounter any issues, please [open an issue on GitHub](https://github.com/auth0/symfony/issues). **Added** - Support for Symfony 7. [\#188](#188) ([mkilmanas](https://github.com/mkilmanas)) - Support string concatenation of scopes. [\#183](#183) ([mkilmanas](https://github.com/mkilmanas)) **Changed** - Dashes in JWT permissions/scopes are now normalized. [\#184](#184) ([mkilmanas](https://github.com/mkilmanas)) **Fixed** - Fixed an issue in controller constructors using a `$container` argument. [\#190)](#190) ([mkilmanas](https://github.com/mkilmanas))
Changes
This is simply allowing Symfony 7 in composer.json - could not find any problems or incompatibilities at this point.
composer test
) are passingReferences
#182
Testing
Attempted to install this bundle on a small Symfony project and perform JWT authentication. Other use-cases should be verified.
Maybe instead of merging to
main
branch, this should be "quarantined" in a dedicated branch (e.g.symfony7
) of this main repository - that way other people would be able to install this version via composer by requiringauth0/symfony: dev-symfony7
and then test on their applications and their use-cases?[ ] This change adds test coverage
[x] This change has been tested on the latest version of Symfony
Checklist
[x] I have read the Auth0 general contribution guidelines
[x] I have read the Auth0 Code of Conduct
[x] All existing and new tests complete without errors