Normalize dashes in JWT permissions/scopes #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkilmanas
force-pushed
the
feature/support-dash-separated-permissions-and-scopes
branch
from
ac824de
to
46f1733
Compare
|
Hey @mkilmanas thanks a lot for contributing this; our team is at an offsite this week so my bandwidth is a little limited, but I'll take a look at this as soon as I'm back at my desk next week. Appreciate it! |
evansims
approved these changes
Jun 24, 2024
evansims
added a commit
that referenced
this pull request
Jun 24, 2024
This release includes experimental community-contributed support for Symfony 7. If you encounter any issues, please [open an issue on GitHub](https://github.com/auth0/symfony/issues). **Added** - Support for Symfony 7. [\#188](#188) ([mkilmanas](https://github.com/mkilmanas)) - Support string concatenation of scopes. [\#183](#183) ([mkilmanas](https://github.com/mkilmanas)) **Changed** - Dashes in JWT permissions/scopes are now normalized. [\#184](#184) ([mkilmanas](https://github.com/mkilmanas)) **Fixed** - Fixed an issue in controller constructors using a `$container` argument. [\#190)](#190) ([mkilmanas](https://github.com/mkilmanas))
Merged
evansims
added a commit
that referenced
this pull request
Jun 24, 2024
This release includes experimental community-contributed support for Symfony 7. If you encounter any issues, please [open an issue on GitHub](https://github.com/auth0/symfony/issues). **Added** - Support for Symfony 7. [\#188](#188) ([mkilmanas](https://github.com/mkilmanas)) - Support string concatenation of scopes. [\#183](#183) ([mkilmanas](https://github.com/mkilmanas)) **Changed** - Dashes in JWT permissions/scopes are now normalized. [\#184](#184) ([mkilmanas](https://github.com/mkilmanas)) **Fixed** - Fixed an issue in controller constructors using a `$container` argument. [\#190)](#190) ([mkilmanas](https://github.com/mkilmanas))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When converting permissions/scopes to Symfony roles, apply replacement not only for colon (
:) character, but also for dash (-) character, as some resources/permissions consist of multiple words and dash is a recommended separator in such cases.Testing
read:licence-plates)ROLE_READ_LICENCE-PLATESROLE_READ_LICENCE_PLATES[ ] This change adds test coverage
[ ] This change has been tested on the latest version of Symfony
Checklist
[x] I have read the Auth0 general contribution guidelines
[x] I have read the Auth0 Code of Conduct
[x] All existing and new tests complete without errors