Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Circle CI with GitHub Actions #154

Closed
wants to merge 1 commit into from

Conversation

jonkoops
Copy link
Contributor

Replaces Circle CI with GitHub Actions, which allows forks to run CI without needing to do additional setup. I needed this for my own purposes, since I wanted to contribute some code, and I figured this might be useful for others as well.

This also bumps all the versions of Node.js to the same ones proposed in #151.

@jonkoops jonkoops requested a review from a team as a code owner July 26, 2023 15:20
@frederikprijck
Copy link
Member

frederikprijck commented Jul 26, 2023

Thanks, but I am going to close this as we have an entire automated release infrastructure set up on top of Circle CI and all of our SDKs and Samples (give or take 90 repositories) run on Circle, sorry for that.

You can see I only recently brought this in on master: #152, still need to get it into this branch as well.

We only recently took ownership of this library, and I wanted to do some housekeeping (hence the beta PR) to set us up for success, which is why we only just now brought in the changes in #152 in this lib.

I can tell we are planning to move everything to Github Actions, but not just yet.

@jonkoops
Copy link
Contributor Author

No problem, this can always be used for future reference 👍

@jonkoops jonkoops deleted the gh-actions branch July 26, 2023 15:25
@frederikprijck
Copy link
Member

Definetly, appreciate it @jonkoops !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants