-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare beta version #151
Prepare beta version #151
Conversation
9c044d1
to
3b9923b
Compare
Thanks to both of you reviewing! I think I addressed all comments, either by making the required changes or by adding a reply. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, future improvements can always be added later.
I am going to leave this one open for a little bit, just to give anyone else from #130 to give feedback. Thanks for the feedback here @jonkoops and @Widcket as well, really appreciate it. I did update the description after both of you approved to mention the decrease in bundle size, which isn't unimportant to call out 🔥 🚀 . |
Side-note, we just landed |
a872cc9
to
51354b3
Compare
force pushed to ensure this branch is up to date with master again so we can properly copy all commits to beta and keep then. |
@frederikprijck I've been reading up a bit on publishing packages in multiple module formats with TypeScript (the TypeScript handbook has a great guide for this). I think we'll have to compile types for each module format, and also slightly adjust the I'm taking a deep dive on this today, so I will hopefully have something more concrete for that soon. But in the mean time I would advice we wait with publishing a new stable, just in case it might cause issues for users. |
Thanks for the feedback. There are no plans to release a new stable, we will cut a beta and gather feedback. So we can always see and adjust 👍 |
@jonkoops I generated the types for both ESM and CJS locally, and they look identical (we have very basic types). So I think we might be good the way we have things configured atm. We might be better of changing it, to be sure for the future. But for now, it looks like it works as is. |
Ok, I will still take another look to be sure. These things unfortunately have many edge cases in my experience. |
I installed the See link here Could you make another release to try out? |
Thanks, our automated release setup wasnt properly ported to this repo (this is the first release we tried with jwt-decode using that, I should have followed up) Fixed in #167, will create a follow up release |
Cut a new release, it looks like it's okay now: https://www.npmjs.com/package/jwt-decode/v/4.0.0-beta.1?activeTab=code Can you try again @cristobal ? |
Description
Prepares the repository for a new beta with the following changes:
exports
field, for better CJS/ESM supportindex.standalone.ts
, but rely on rollup instead.header
argument by using overloads.Additionally, this PR ensures the file size is decreased:
Even though some users might experience breaking changes, mostly because of the
exports
field, the majority should be able to update without making any changes, assuming the SDK is used in environments with support for atob.References
This beta is mostly created as a result of #145 , as it makes sense to drop the polyfil but we feel like we do not want to do this in a non-major given the extensive usage of this SDK.
Testing
Checklist