Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.8.1 #254

Merged
merged 2 commits into from
Dec 7, 2021
Merged

Release v1.8.1 #254

merged 2 commits into from
Dec 7, 2021

Conversation

frederikprijck
Copy link
Member

Changed

Fixed

@frederikprijck frederikprijck requested a review from a team as a code owner December 7, 2021 08:53
@frederikprijck frederikprijck added the review:small Small review label Dec 7, 2021
@frederikprijck frederikprijck merged commit c3629d3 into master Dec 7, 2021
@frederikprijck frederikprijck deleted the release/v1.8.1 branch December 7, 2021 15:46
@sbubaron
Copy link

sbubaron commented Dec 9, 2021

FYI/FWIW I had to manually add/install the latest version of @auth0/auth0-spa-js in order to get my Angular 13 app to properly compile. Prior to doing that I was getting an error along the lines of: Module @auth0/auth0-spa-js has no exported member GetTokenSilentlyVerboseResponse and another error along the lines of: Type 'RedirectLoginResult' is not generic

package.json

  "@auth0/auth0-angular": "^1.8.1",
    "@auth0/auth0-spa-js": "^1.19.3"

@frederikprijck
Copy link
Member Author

frederikprijck commented Dec 9, 2021

Interesting, thanks for reporting this @sbubaron .

I haven't been able to reproduce this. But I am very interested to understand why you are getting this behavior.

  • When using npm install @auth0/auth0-angular in a new project, it installs @auth0/auth0-spa-js 1.19.3.
  • When using a project that already had an older version of @auth0/auth0-angular installed, and implicitly also an older version of @auth0/auth0-spa-js, running npm install @auth0/auth0-angular@latest also upgrades @auth0/auth0-spa-js to 1.19.3.

Did you perhaps already have an entry for @auth0/auth0-spa-js in your package.json before upgrading @auth0/auth0-angular to 1.8.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants