Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing angular/router to peerDependencies #242

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Add missing angular/router to peerDependencies #242

merged 1 commit into from
Nov 15, 2021

Conversation

klaascuvelier
Copy link
Contributor

Description

auth0-angular has a dependency on angular/router that is not specified in the peerDependencies.

References

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

`auth0-angular` has a dependency on `angular/router` that is not specified in the `peerDependencies`. 

Found this out by trying to set up a stackblitz with `auth0-angular` (https://twitter.com/MarkWhitfeld/status/1460231742774722562)
@klaascuvelier klaascuvelier requested a review from a team as a code owner November 15, 2021 13:09
@klaascuvelier klaascuvelier changed the title Update package.json Add missing angular/router to peerDependencies Nov 15, 2021
Copy link
Member

@frederikprijck frederikprijck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stevehobbsdev stevehobbsdev merged commit 990e02e into auth0:master Nov 15, 2021
@frederikprijck frederikprijck added the CH: Fixed PR is fixing a bug label Dec 7, 2021
@frederikprijck frederikprijck added this to the v1.8.1 milestone Dec 7, 2021
@frederikprijck frederikprijck mentioned this pull request Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CH: Fixed PR is fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants