Make sure to support 8.1 #209
Conversation
|
I ran tests on PHP 8.1. Is it okay? |
|
Hey @kenjis , That was phpunit configuration issue. I have changed it now. The tests are running on 8.1, you can see in github actions. |
|
@harikt Okay, I've confirmed the warnings are gone. |
| @@ -105,6 +106,9 @@ public function testConnectionQueries() | |||
|
|
|||
| // make sure new encoding was honored | |||
| $actual = $pdo->fetchValue('PRAGMA encoding'); | |||
|
|
|||
| // When changing to UTF-16, sometimes it is returning UTF-16le | |||
| // $this->assertEquals($newEncoding, $actual); | |||
There was a problem hiding this comment.
Can anyone of you run the test uncommenting the line ?
This is what I get
There was a problem hiding this comment.
$ vendor/bin/phpunit tests/ExtendedPdoTest.php
PHPUnit 9.5.16 by Sebastian Bergmann and contributors.
.F............................................ 46 / 46 (100%)
Time: 00:00.090, Memory: 6.00 MB
There was 1 failure:
1) Aura\Sql\ExtendedPdoTest::testConnectionQueries
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'UTF-16'
+'UTF-16le'
|
Someone thought I am disrespectful to them. YOURLS/YOURLS#3230 (comment) . I am not sure if I did something wrong helping the project. Let me step back. |
|
It seems they were mad because they thought their PR was closed without any explanation. |
|
Yes, I'm not mad about the PR itself, but more about the way it has been managed. Yes indeed, my PR has been closed without any explanation, and yes this is contributor harmful. Also @harikt, be careful with who helps who. We never asked for any help on the mentioned project, YOURLS. |
|
Hey @LeoColomb , Firstly and lastly I apologize if you felt I was rude. Normally I used to wait for the changes so that people get credits for what they deserve. Today I noticed a closed PR. I thought this was closed by you. Again I didn't closed it myself. If so it may have happened by an accident. If you got an email stating harikt closed the issue, can you post a screenshot? I am also curious to know what really happened. |
|
Normally it shows who and when closed: But the PR's closed comment is different: |
|
Indeed, I didn't received any email about the closure and more importantly my fork does not exist anymore for no reason. So, should I recreate my PR? |
No. This has been addressed currently. Thank you for your time. |
|
I was just about to request GitHub support too! |
|
This is very weird. @LeoColomb I know how it is when someone has been rude on the internet -- it makes you feel frustrated and angry and you want to push back in return. But if you will take my word for it, @harikt is one of the most polite and respectful people I know, so any sense of rudeness was sure to be a miscommunication. Thank you @LeoColomb for your patience and understanding. |
|
Support responded.
It's not like any person closed the PR directly. |
|
Thank you @pmjones , @koriym , @kenjis for taking your valuable time and trying to resolve the misunderstanding happened due to an event with github. @LeoColomb lets forget the bad stuffs and move on. Have a nice day ahead. With love Hari |
Trying to address #194 , #208 .
Some credits for #204