Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.x - fix broken return types - adjust minimum php version to 8.0 since no 8.1 features are being used #204

Merged
merged 8 commits into from
Feb 17, 2022

Conversation

r4ndsen
Copy link

@r4ndsen r4ndsen commented Jan 12, 2022

No description provided.

@r4ndsen r4ndsen changed the title 5.x 5.x - fix broken return types - adjust minimum php version to 8.0 since no 8.1 features are being used Jan 12, 2022
@r4ndsen r4ndsen mentioned this pull request Jan 12, 2022
@Morthy
Copy link

Morthy commented Feb 2, 2022

It would be great to see this merged because this is currently preventing us from upgrading to PHP 8.1 in our project

@harikt
Copy link
Member

harikt commented Feb 8, 2022

@Morthy what feature in this PR is preventing you to upgrade to PHP 8.1 ?

Looks all tests in 8.1 is working https://github.com/auraphp/Aura.Sql/runs/4577260986?check_suite_focus=true

composer.json Outdated Show resolved Hide resolved
@Morthy
Copy link

Morthy commented Feb 8, 2022

@Morthy what feature in this PR is preventing you to upgrade to PHP 8.1 ?

Looks all tests in 8.1 is working https://github.com/auraphp/Aura.Sql/runs/4577260986?check_suite_focus=true

This PR fixes the fatal TypeErrors that occur due to the wrong return types present in the 4.x and 5.x branch. If the 3.x branch is used, there are instead many deprecation notices due to incompatibility with the PDO methods. So basically 4.x and above are unusable on PHP 8.1 if you have any case like doing a fetchObject() call that returns no rows.

@harikt
Copy link
Member

harikt commented Feb 9, 2022

@Morthy ok, I will look into this.

src/PdoInterface.php Outdated Show resolved Hide resolved
@harikt
Copy link
Member

harikt commented Feb 17, 2022

Note : In the mean time if you want to push your code to 8.1 you can also do something like in example https://getcomposer.org/doc/05-repositories.md#loading-a-package-from-a-vcs-repository .

@harikt harikt merged commit 17215ae into auraphp:5.x Feb 17, 2022
@harikt
Copy link
Member

harikt commented Feb 19, 2022

Hi all,

Thanks for your contributions.

I have tagged 5.0.1 .

@harikt harikt mentioned this pull request Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants