-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.x - fix broken return types - adjust minimum php version to 8.0 since no 8.1 features are being used #204
Conversation
It would be great to see this merged because this is currently preventing us from upgrading to PHP 8.1 in our project |
@Morthy what feature in this PR is preventing you to upgrade to PHP 8.1 ? Looks all tests in 8.1 is working https://github.com/auraphp/Aura.Sql/runs/4577260986?check_suite_focus=true |
This PR fixes the fatal TypeErrors that occur due to the wrong return types present in the 4.x and 5.x branch. If the 3.x branch is used, there are instead many deprecation notices due to incompatibility with the PDO methods. So basically 4.x and above are unusable on PHP 8.1 if you have any case like doing a fetchObject() call that returns no rows. |
@Morthy ok, I will look into this. |
Note : In the mean time if you want to push your code to 8.1 you can also do something like in example https://getcomposer.org/doc/05-repositories.md#loading-a-package-from-a-vcs-repository . |
Hi all, Thanks for your contributions. I have tagged 5.0.1 . |
No description provided.