Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login failed in version 6.3.0 #283

Closed
tgly307 opened this issue Jan 15, 2022 · 3 comments · Fixed by #284
Closed

Login failed in version 6.3.0 #283

tgly307 opened this issue Jan 15, 2022 · 3 comments · Fixed by #284
Assignees

Comments

@tgly307
Copy link
Contributor

tgly307 commented Jan 15, 2022

Describe the bug
Update mm_server from 6.2.0 to 6.3.0, the bot login failed.
The log is:

[01/16/2022 02:44:18][mattermostdriver.websocket][WARNING] Failed to establish websocket connection: code = 1006 (connection closed abnormally [internal]), no reason
[2022-01-16 02:44:18,257][mattermostdriver.websocket][WARNING] Failed to establish websocket connection: code = 1006 (connection closed abnormally [internal]), no reason

How To Reproduce
Give us simple steps to reproduce the behavior:
Update mm_server from 6.2.0 to 6.3.0
start bot
Expected behavior
A clear and concise description of what you expected to happen.
Log in normally
Operating Environment (please complete the following information):

  • OS: [Linux]
  • Python Version: [3.8]
  • Mattermost Version: [6.3.0]
  • mmpy_bot Version: [2.0.2]

Additional context
Add any other context about the problem here [e.g. Settings for your bot, API Version]

@ttuffin
Copy link
Collaborator

ttuffin commented Jan 18, 2022

Thanks for logging the issue. Looks like this may be a direct cause of mattermost/mattermost#19128.

I see a PR has been logged upstream for mattermost-driver: Vaelor/python-mattermost-driver#111

I tested it and it resolved the issue for me also. Once that is merged and released we can update our dependency mapping to the new version.

@ttuffin ttuffin closed this as completed Jan 18, 2022
@ttuffin ttuffin reopened this Jan 18, 2022
@ttuffin ttuffin self-assigned this Jan 18, 2022
@tgly307
Copy link
Contributor Author

tgly307 commented Jan 19, 2022

Thank you for your reply. I didn't notice this PR before. Will this change cause that the servers before 6.3.0 cannot be logged in?

@ttuffin
Copy link
Collaborator

ttuffin commented Jan 19, 2022

I posted this to the mattermost-driver issue as well:

I have not had any issues when testing this change against MM 5.26.0, which also uses API v4. It may break for API v3, but since it has been deprecated since 2018 I don't think it's a blocker.

Further, I don't see any particular need for the authentication data to be encoded, except that it consumes slightly less memory (a negligable difference). Prior to MM-40485, sending non-encoded data works fine as well, but now that they have changed the decoder it seems to no longer accept UTF encoded data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants