FIX: Removed encode("utf-8") from websocket authentication #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes compatibility with Mattermost 6.3.0
|
Hi @Vaelor, are you able to take a look at this PR please? Looks like a change to Mattermost's websocket handling in 6.3.0 broke the authentication method. This PR resolved the issue for me also. |
|
I have a question, will this change affect the previous mm server version? |
|
I have not had any issues when testing this change against MM 5.26.0, which also uses API v4. It may break for API v3, but since it has been deprecated since 2018 I don't think it's a blocker. |
|
Thanks for finding this. I checked with Version 6, and it works there too. APIv3 isn't supported anymore anyway by this repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes compatibility with Mattermost 6.3.0
Without this I was getting 1006 error when calling init_websocket after upgrade to mattermost 6.3.0