Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace eslint style rules with prettier #552

Closed
alexreardon opened this issue Jun 18, 2018 · 2 comments
Closed

Replace eslint style rules with prettier #552

alexreardon opened this issue Jun 18, 2018 · 2 comments

Comments

@alexreardon
Copy link
Collaborator

Right now we have a lot of eslint rules including extending the airbnb rules.

I am keen to move all of the style rules to prettier (eg our custom eslint rule for dangling comma's)

However, I am keen to keep the eslint rules that are non-style related. Things like eslint-plugin-jsx-a11y and so on.

Here is my proposed .prettierrc config

{
  "trailingComma": "all",
  "semi": true,
  "tabWidth": 2,
  "useTabs": false,
  "singleQuote": true
}
@alexreardon
Copy link
Collaborator Author

This work should be done after #493, and probably at the same time as #525

alexreardon added a commit that referenced this issue Jun 26, 2018
@alexreardon
Copy link
Collaborator Author

Shipped in #581

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant